[GitHub] [hadoop] tasanuma commented on a change in pull request #4069: HDFS-16457.Make fs.getspaceused.classname reconfigurable

[GitBox <gi...@apache.org>]

tasanuma commented on a change in pull request #4069:
URL: https://github.com/apache/hadoop/pull/4069#discussion_r839809073



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeReconfiguration.java
##########
@@ -756,4 +759,33 @@ public void testDfsUsageParameters() throws ReconfigurationException {
       }
     }
   }
+
+  public static class DummyCachingGetSpaceUsed extends CachingGetSpaceUsed {
+    public DummyCachingGetSpaceUsed(Builder builder) throws IOException {
+      super(builder.setInterval(1000).setJitter(0L));
+    }
+
+    @Override
+    protected void refresh() {
+      counter++;
+    }
+  }
+
+  @Test
+  public void testDfsUsageKlass() throws IOException, ReconfigurationException,
+          InterruptedException {
+
+    long lastCounter = counter;
+    Thread.sleep(5000);
+    assertTrue(counter > lastCounter);
+
+    for (int i = 0; i < NUM_DATA_NODE; i++) {
+      DataNode dn = cluster.getDataNodes().get(i);
+      dn.reconfigurePropertyImpl(FS_GETSPACEUSED_CLASSNAME, null);
+    }
+
+    lastCounter = counter;
+    Thread.sleep(5000);
+    assertEquals(lastCounter, counter);
+ }

Review comment:
       @singer-bin Thanks for updating the PR.
   How about we stop using `conf.setClass` in `startDFCluster`, and reconfigure `DummyCachingGetSpaceUsed` in the unit test, and replace the order of the assertions? (But after this change, somehow the unit test failed.)
   ```suggestion
     @Test
     public void testDfsUsageKlass() throws IOException, ReconfigurationException,
             InterruptedException {
   
       long lastCounter = counter;
       Thread.sleep(5000);
       assertEquals(lastCounter, counter);
   
       for (int i = 0; i < NUM_DATA_NODE; i++) {
         DataNode dn = cluster.getDataNodes().get(i);
         dn.reconfigurePropertyImpl(FS_GETSPACEUSED_CLASSNAME, DummyCachingGetSpaceUsed.class.toString());
       }
   
       lastCounter = counter;
       Thread.sleep(5000);
       assertTrue(counter > lastCounter);
    }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org