You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/01 03:02:32 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #614: Compile lua by C++ compilers to avoid memory leaks

PragmaTwice commented on code in PR #614:
URL: https://github.com/apache/incubator-kvrocks/pull/614#discussion_r886279859


##########
src/scripting.cc:
##########
@@ -74,12 +74,10 @@ enum {
   LL_WARNING,
 };
 
-extern "C" {

Review Comment:
   Sorry, the error is caused by a typo in cmake, I have fixed it in the latest commit.
   If `extern "C"` is added, the linker will fail, since we compile lua by c++ compiler and so these lua symbols is mangled by Itanium C++ ABI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org