[GitHub] bigtop pull request #352: BIGTOP-3022 Auto find of latest Ant

[acmnu <gi...@git.apache.org>]

GitHub user acmnu opened a pull request:

    https://github.com/apache/bigtop/pull/352

    BIGTOP-3022 Auto find of latest Ant

    That patch allow to derminate latest version of Ant
    available on apache dist.
    
    There is one restriction. We query main apache mirror instead
    of nearest one because we can't be sure it use Apache with same
    configuration as main.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arenadata/bigtop BIGTOP-3022

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bigtop/pull/352.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #352
    
----
commit 260ad4e793e158400834d6c6ab764fab6969f91f
Author: Anton Chevychalov <ca...@...>
Date:   2018-04-17T11:20:39Z

    BIGTOP-3022 Auto find of latest Ant
    
    That patch allow to derminate latest version of Ant
    available on apache dist.
    
    There is one restriction. We query main apache mirror instead
    of nearest one because we can't be sure it use Apache with same
    configuration as main.

----


---

[GitHub] bigtop issue #352: BIGTOP-3022 Auto find of latest Ant

[acmnu <gi...@git.apache.org>]

Github user acmnu commented on the issue:

    https://github.com/apache/bigtop/pull/352
  
    @evans-ye, I changed function. It's support parameter now.


---

[GitHub] bigtop pull request #352: BIGTOP-3022 Auto find of latest Ant

[evans-ye <gi...@git.apache.org>]

Github user evans-ye commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/352#discussion_r182319574
  
    --- Diff: bigtop_toolchain/lib/puppet/parser/functions/latest_ant_binary.rb ---
    @@ -0,0 +1,20 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +
    +module Puppet::Parser::Functions
    +    newfunction(:latest_ant_binary, :type => :rvalue) do |args|
    +        %x(curl --stderr /dev/null 'https://www.apache.org/dist/ant/binaries/?F=0&V=1' | grep -o '<li>.*href="apache-ant.*-bin.tar.gz"'  |  grep -o "apache-ant-1.9.[0-9]*" | tail -1 | tr -d '\r').chomp
    --- End diff --
    
    Looks like we can only auto select ant 1.9.X. Any chance we can improve it?
    Or, at lease we change the function name to reflect the limitation.


---