[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #166: Update Hive Metastore tables for Spark

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #166: Update Hive Metastore tables for Spark
URL: https://github.com/apache/incubator-iceberg/pull/166#discussion_r277351737
 
 

 ##########
 File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
 ##########
 @@ -126,7 +127,7 @@ public void commit(TableMetadata base, TableMetadata metadata) {
       // TODO add lock heart beating for cases where default lock timeout is too low.
       Table tbl;
       if (base != null) {
-        tbl = metaStoreClient.get_table(database, tableName);
+        tbl = metaClients.run(client -> client.getTable(database, tableName));
 
 Review comment:
   One question that is not related to this change. Am I correct that we don't refresh the metadata after we require the lock?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org