You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Marc Strapetz <ma...@syntevo.com> on 2008/03/03 12:55:34 UTC
Changelists don't work with directories
I have tried to add a directory to a changelist with "svn --changelist
clname dir" but there happens nothing. I would expect the directory
being non-recursively added to the changelist (--depth=empty). Or do
changelists intentionally not work on directories?
I was using the Windows beta build from CollabNet's "Merge Tracking
Early Adopter Program". Btw, it's very convenient to have these
pre-built binaries supplied.
--
Best regards,
Marc Strapetz
_____________
SyntEvo GmbH
www.syntevo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Changelists don't work with directories
Posted by "C. Michael Pilato" <cm...@collab.net>.
C. Michael Pilato wrote:
> David Glasser wrote:
>> However, I think we should either make "svn cl" recursive by default
>> (so that "svn cl foo dir" adds all the file descendents of "dir" to
>> "foo"), or print a warning for each directory. Daniel Shahaf wrote
>> some patches to accomplish these. I'm actually starting to change my
>> mind and think that defaulting to empty is OK, as long as the warnings
>> are printed.
>
> My vote is (and has been) for depth-empty with printed warnings, and it
> is that patch which I plan to review and commit unless someone objects.
> (After all, I helped to write that patch.)
Committed:
Sending subversion/libsvn_client/changelist.c
Sending subversion/tests/cmdline/changelist_tests.py
Transmitting file data ..
Committed revision 29671.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: Changelists don't work with directories
Posted by David Glasser <gl...@davidglasser.net>.
On Mon, Mar 3, 2008 at 8:14 AM, C. Michael Pilato <cm...@collab.net> wrote:
> David Glasser wrote:
> > However, I think we should either make "svn cl" recursive by default
> > (so that "svn cl foo dir" adds all the file descendents of "dir" to
> > "foo"), or print a warning for each directory. Daniel Shahaf wrote
> > some patches to accomplish these. I'm actually starting to change my
> > mind and think that defaulting to empty is OK, as long as the warnings
> > are printed.
>
> My vote is (and has been) for depth-empty with printed warnings, and it is
> that patch which I plan to review and commit unless someone objects. (After
> all, I helped to write that patch.)
+1
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Changelists don't work with directories
Posted by "C. Michael Pilato" <cm...@collab.net>.
David Glasser wrote:
> However, I think we should either make "svn cl" recursive by default
> (so that "svn cl foo dir" adds all the file descendents of "dir" to
> "foo"), or print a warning for each directory. Daniel Shahaf wrote
> some patches to accomplish these. I'm actually starting to change my
> mind and think that defaulting to empty is OK, as long as the warnings
> are printed.
My vote is (and has been) for depth-empty with printed warnings, and it is
that patch which I plan to review and commit unless someone objects. (After
all, I helped to write that patch.)
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: Changelists don't work with directories
Posted by David Glasser <gl...@davidglasser.net>.
On Mon, Mar 3, 2008 at 4:55 AM, Marc Strapetz <ma...@syntevo.com> wrote:
> I have tried to add a directory to a changelist with "svn --changelist
> clname dir" but there happens nothing. I would expect the directory
> being non-recursively added to the changelist (--depth=empty). Or do
> changelists intentionally not work on directories?
There's a couple questions here:
* Should changelists work on directories?
* If not, what should "svn cl foo dir" do?
I'm OK with keeping changelists from directories for 1.5; we took away
the support for a reason, it's a reasonable feature without them, and
adding more complexity to 1.5 will make it even harder to finish.
However, I think we should either make "svn cl" recursive by default
(so that "svn cl foo dir" adds all the file descendents of "dir" to
"foo"), or print a warning for each directory. Daniel Shahaf wrote
some patches to accomplish these. I'm actually starting to change my
mind and think that defaulting to empty is OK, as long as the warnings
are printed.
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Changelists don't work with directories
Posted by Julian Foad <ju...@btopenworld.com>.
Julian Foad wrote:
> Mark Phippard wrote:
>> On Mon, Mar 3, 2008 at 7:55 AM, Marc Strapetz
>> <ma...@syntevo.com> wrote:
>>
>>> I have tried to add a directory to a changelist with "svn --changelist
>>> clname dir" but there happens nothing. I would expect the directory
>>> being non-recursively added to the changelist (--depth=empty). Or do
>>> changelists intentionally not work on directories?
>>
>> Changelists do not support directories.
>
> Until directories are supported, I'd say it's a bug that it doesn't
> presently warn when skipping the specified directory.
Filed as Issue #3114 <http://subversion.tigris.org/issues/show_bug.cgi?id=3114>.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Changelists don't work with directories
Posted by Julian Foad <ju...@btopenworld.com>.
Mark Phippard wrote:
> On Mon, Mar 3, 2008 at 7:55 AM, Marc Strapetz <ma...@syntevo.com> wrote:
>
>>I have tried to add a directory to a changelist with "svn --changelist
>> clname dir" but there happens nothing. I would expect the directory
>> being non-recursively added to the changelist (--depth=empty). Or do
>> changelists intentionally not work on directories?
>
> Changelists do not support directories.
Until directories are supported, I'd say it's a bug that it doesn't presently
warn when skipping the specified directory.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Changelists don't work with directories
Posted by Mark Phippard <ma...@gmail.com>.
On Mon, Mar 3, 2008 at 10:48 AM, Ben Collins-Sussman
<su...@red-bean.com> wrote:
> We should file a 1.6 enhancement request, don't you think?
Assuming there is not one already, I agree. I recall this was mainly
about not having the time to figure out how the UI should handle all
of the cases, so we just decided to shut off the ability. So it
should be possible to revisit this with the current design.
It also possible that the filtering changes that were made in the UI
have clarified the issues. I have not really spent any time thinking
about it.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Changelists don't work with directories
Posted by Ben Collins-Sussman <su...@red-bean.com>.
We should file a 1.6 enhancement request, don't you think?
On Mon, Mar 3, 2008 at 8:39 AM, Marc Strapetz <ma...@syntevo.com> wrote:
> > It looks like the notes file for changelists does not mention the
> > reason, it probably should. I went back to the mailing list archives,
> > and I believe it was this thread that led to the removal of
> > directories.
>
> Thanks for clarifying this. So +1 from me for supporting directories
> here -- in whatever version.
>
> Just for your information, we had introduced "Change Sets" in SmartSVN a
> while ago with support for directories (only --depth=empty). I can't
> estimate how many people are using this feature but we didn't get any
> bad feedback here. So my personal conclusion is that at least
> --depth=empty directories in changelists seem to be a quite "natural"
> concept resp. easy to understand for the user.
>
>
> --
> Best regards,
> Marc Strapetz
> _____________
> SyntEvo GmbH
> www.syntevo.com
>
>
>
> Mark Phippard wrote:
>
> > On Mon, Mar 3, 2008 at 8:16 AM, Marc Strapetz <ma...@syntevo.com> wrote:
> >> > Changelists do not support directories.
> >>
> >> Are there specific reasons for not supporting directories? A use case
> >> I'm encountering frequently is updating some externals and fixing some
> >> project files for the new externals version.
> >
> > It looks like the notes file for changelists does not mention the
> > reason, it probably should. I went back to the mailing list archives,
> > and I believe it was this thread that led to the removal of
> > directories.
> >
> > http://svn.haxx.se/dev/archive-2007-10/0297.shtml
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Changelists don't work with directories
Posted by Marc Strapetz <ma...@syntevo.com>.
> It looks like the notes file for changelists does not mention the
> reason, it probably should. I went back to the mailing list archives,
> and I believe it was this thread that led to the removal of
> directories.
Thanks for clarifying this. So +1 from me for supporting directories
here -- in whatever version.
Just for your information, we had introduced "Change Sets" in SmartSVN a
while ago with support for directories (only --depth=empty). I can't
estimate how many people are using this feature but we didn't get any
bad feedback here. So my personal conclusion is that at least
--depth=empty directories in changelists seem to be a quite "natural"
concept resp. easy to understand for the user.
--
Best regards,
Marc Strapetz
_____________
SyntEvo GmbH
www.syntevo.com
Mark Phippard wrote:
> On Mon, Mar 3, 2008 at 8:16 AM, Marc Strapetz <ma...@syntevo.com> wrote:
>> > Changelists do not support directories.
>>
>> Are there specific reasons for not supporting directories? A use case
>> I'm encountering frequently is updating some externals and fixing some
>> project files for the new externals version.
>
> It looks like the notes file for changelists does not mention the
> reason, it probably should. I went back to the mailing list archives,
> and I believe it was this thread that led to the removal of
> directories.
>
> http://svn.haxx.se/dev/archive-2007-10/0297.shtml
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Changelists don't work with directories
Posted by Mark Phippard <ma...@gmail.com>.
On Mon, Mar 3, 2008 at 8:16 AM, Marc Strapetz <ma...@syntevo.com> wrote:
> > Changelists do not support directories.
>
> Are there specific reasons for not supporting directories? A use case
> I'm encountering frequently is updating some externals and fixing some
> project files for the new externals version.
It looks like the notes file for changelists does not mention the
reason, it probably should. I went back to the mailing list archives,
and I believe it was this thread that led to the removal of
directories.
http://svn.haxx.se/dev/archive-2007-10/0297.shtml
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Changelists don't work with directories
Posted by Marc Strapetz <ma...@syntevo.com>.
> Changelists do not support directories.
Are there specific reasons for not supporting directories? A use case
I'm encountering frequently is updating some externals and fixing some
project files for the new externals version.
--
Best regards,
Marc Strapetz
_____________
SyntEvo GmbH
www.syntevo.com
Mark Phippard wrote:
> On Mon, Mar 3, 2008 at 7:55 AM, Marc Strapetz <ma...@syntevo.com> wrote:
>> I have tried to add a directory to a changelist with "svn --changelist
>> clname dir" but there happens nothing. I would expect the directory
>> being non-recursively added to the changelist (--depth=empty). Or do
>> changelists intentionally not work on directories?
>
> Changelists do not support directories.
>
>> I was using the Windows beta build from CollabNet's "Merge Tracking
>> Early Adopter Program". Btw, it's very convenient to have these
>> pre-built binaries supplied.
>
> Keep in mind, that we do not have alpha2 posted yet. Probably today
> or tomorrow.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Changelists don't work with directories
Posted by Mark Phippard <ma...@gmail.com>.
On Mon, Mar 3, 2008 at 7:55 AM, Marc Strapetz <ma...@syntevo.com> wrote:
> I have tried to add a directory to a changelist with "svn --changelist
> clname dir" but there happens nothing. I would expect the directory
> being non-recursively added to the changelist (--depth=empty). Or do
> changelists intentionally not work on directories?
Changelists do not support directories.
> I was using the Windows beta build from CollabNet's "Merge Tracking
> Early Adopter Program". Btw, it's very convenient to have these
> pre-built binaries supplied.
Keep in mind, that we do not have alpha2 posted yet. Probably today
or tomorrow.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org