You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jim Plush (JIRA)" <ji...@apache.org> on 2012/08/06 00:02:02 UTC

[jira] [Created] (KAFKA-438) Code cleanup in MessageTest

Jim Plush created KAFKA-438:
-------------------------------

             Summary: Code cleanup in MessageTest
                 Key: KAFKA-438
                 URL: https://issues.apache.org/jira/browse/KAFKA-438
             Project: Kafka
          Issue Type: Improvement
          Components: core
            Reporter: Jim Plush
            Priority: Trivial


While exploring the Unit Tests this class had an unused import statement, some ambiguity on which HashMap implementation was being used and assignments of function returns when not required. 

Trivial stuff

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (KAFKA-438) Code cleanup in MessageTest

Posted by "Jim Plush (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Plush updated KAFKA-438:
----------------------------

    Attachment: KAFKA-438

patch file uploaded
                
> Code cleanup in MessageTest
> ---------------------------
>
>                 Key: KAFKA-438
>                 URL: https://issues.apache.org/jira/browse/KAFKA-438
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.7.1
>            Reporter: Jim Plush
>            Priority: Trivial
>             Fix For: 0.8
>
>         Attachments: KAFKA-438
>
>
> While exploring the Unit Tests this class had an unused import statement, some ambiguity on which HashMap implementation was being used and assignments of function returns when not required. 
> Trivial stuff

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (KAFKA-438) Code cleanup in MessageTest

Posted by "Jim Plush (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Plush updated KAFKA-438:
----------------------------

        Fix Version/s: 0.8
    Affects Version/s: 0.7.1
               Status: Patch Available  (was: Open)

cleanup 
* was using HashMap when rest of codebase seems to prefix with mutable.HashMap
* removed assignments from Unit response test functions e.g. removed the "="	
                
> Code cleanup in MessageTest
> ---------------------------
>
>                 Key: KAFKA-438
>                 URL: https://issues.apache.org/jira/browse/KAFKA-438
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.7.1
>            Reporter: Jim Plush
>            Priority: Trivial
>             Fix For: 0.8
>
>         Attachments: KAFKA-438
>
>
> While exploring the Unit Tests this class had an unused import statement, some ambiguity on which HashMap implementation was being used and assignments of function returns when not required. 
> Trivial stuff

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira