You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rambleraptor (via GitHub)" <gi...@apache.org> on 2025/06/17 23:14:04 UTC

[PR] source-ids is not supported on Iceberg v1,2 [iceberg-python]

rambleraptor opened a new pull request, #2114:
URL: https://github.com/apache/iceberg-python/pull/2114

   <!--
   Thanks for opening a pull request!
   -->
   
   <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
   Closes #1547
   
   # Rationale for this change
   The field `source-ids` is being introduced for Iceberg v3. According to the spec, it should not be supported by Iceberg v1 + v2. This introduces an error message to ensure that it cannot be used in those versions.
   
   Most of the code here is to plumb through the format_version to the field to do the actual version check.
   
   # Are these changes tested?
   Unit tests included.
   
   # Are there any user-facing changes?
   This does change the current support for `source-ids` on Iceberg v1/v2, but it shouldn't be supported in the first place.
   
   <!-- In the case of user-facing changes, please add the changelog label. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] source-ids is not supported on Iceberg v1,2 [iceberg-python]

Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on code in PR #2114:
URL: https://github.com/apache/iceberg-python/pull/2114#discussion_r2155461407


##########
pyiceberg/partitioning.py:
##########
@@ -86,6 +86,7 @@ class PartitionField(IcebergBaseModel):
 
     def __init__(
         self,
+        format_version: Optional[int] = None,

Review Comment:
   Agreed. (See note below)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] source-ids is not supported on Iceberg v1,2 [iceberg-python]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #2114:
URL: https://github.com/apache/iceberg-python/pull/2114#discussion_r2155332678


##########
pyiceberg/partitioning.py:
##########
@@ -86,6 +86,7 @@ class PartitionField(IcebergBaseModel):
 
     def __init__(
         self,
+        format_version: Optional[int] = None,

Review Comment:
   This breaks the current API. When existing users create a PartitionField, they expect the first argument to be `source-id`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] source-ids is not supported on Iceberg v1,2 [iceberg-python]

Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on PR #2114:
URL: https://github.com/apache/iceberg-python/pull/2114#issuecomment-2985637012

   That makes a lot of sense for v3. But, it looks like `source-ids` is supported on v1/v2, which the spec explicitly disallows. We'd have to carry through the table version to fix that. If that doesn't seem like a serious issue, happy to close this PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org