[GitHub] [ignite] anton-vinogradov commented on a diff in pull request #10018: IGNITE-16938 StoredCacheData logic moved to GridLocalConfigManager

[GitBox <gi...@apache.org>]

anton-vinogradov commented on code in PR #10018:
URL: https://github.com/apache/ignite/pull/10018#discussion_r870149076


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java:
##########
@@ -3088,7 +3093,7 @@ public LocalSnapshotSender(String snpName) {
 
                     cacheData.groupKeyEncrypted(new GroupKeyEncrypted(gKey.id(), encSpi.encryptKey(gKey.key())));
 
-                    storeMgr.writeCacheData(cacheData, targetCacheCfg);
+                    cctx.cache().configManager().writeCacheData(cacheData, targetCacheCfg);

Review Comment:
   cctx.cache().configManager() already stored to the locCfgMgr?



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java:
##########
@@ -1624,7 +1624,11 @@ private String cacheInfo(GridCacheContext cacheCtx) {
                 CacheGroupContext grp = tup.get1();
 
                 try {
-                    cctx.pageStore().shutdownForCacheGroup(grp, tup.get2());
+                    boolean destroy = tup.get2();

Review Comment:
   newline missed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org