You are viewing a plain text version of this content. The canonical link for it is here.
Posted to npanday-commits@incubator.apache.org by "Adrián Boimvaser (Created JIRA)" <ji...@apache.org> on 2012/01/16 13:02:39 UTC
[jira] [Created] (NPANDAY-533) Refactor wix-maven-plugin to reduce
duplication
Refactor wix-maven-plugin to reduce duplication
-----------------------------------------------
Key: NPANDAY-533
URL: https://issues.apache.org/jira/browse/NPANDAY-533
Project: NPanday
Issue Type: Improvement
Components: Maven Plugins
Affects Versions: 1.5.0-incubating
Reporter: Adrián Boimvaser
Fix For: 1.5.0-incubating
Attachments: wixMavenPluginRefactored.patch
I refactored the wix-maven-plugin to:
* Reduce some duplication
* Take advantage of the enhanced for loop
* Simplify the control flow in cases where: if (condition) { throw ... } else { ... }
can be better expressed as: if (condition) { throw ... } ...
I also added a couple configuration options: supressSchemaValidation (-ss) & cultures (-cultures)
I attach the patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NPANDAY-533) Refactor wix-maven-plugin to
reduce duplication
Posted by "Brett Porter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188466#comment-13188466 ]
Brett Porter commented on NPANDAY-533:
--------------------------------------
No problem. To run the ITs in future, just run: {{mvn -Prun-its clean install}}. This works for an individual plugin, or from the top level (where it will also run the full npanday-its suite). You can also see our builds at https://builds.apache.org/view/M-R/view/NPanday/
> Refactor wix-maven-plugin to reduce duplication
> -----------------------------------------------
>
> Key: NPANDAY-533
> URL: https://issues.apache.org/jira/browse/NPANDAY-533
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.5.0-incubating
> Reporter: Adrián Boimvaser
> Assignee: Brett Porter
> Fix For: 1.5.0-incubating
>
> Attachments: wixMavenPluginRefactored.patch
>
>
> I refactored the wix-maven-plugin to:
> * Reduce some duplication
> * Take advantage of the enhanced for loop
> * Simplify the control flow in cases where: if (condition) { throw ... } else { ... }
> can be better expressed as: if (condition) { throw ... } ...
> I also added a couple configuration options: supressSchemaValidation (-ss) & cultures (-cultures)
> I attach the patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NPANDAY-533) Refactor wix-maven-plugin to reduce
duplication
Posted by "Adrián Boimvaser (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrián Boimvaser updated NPANDAY-533:
-------------------------------------
Attachment: wixMavenPluginRefactored.patch
> Refactor wix-maven-plugin to reduce duplication
> -----------------------------------------------
>
> Key: NPANDAY-533
> URL: https://issues.apache.org/jira/browse/NPANDAY-533
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.5.0-incubating
> Reporter: Adrián Boimvaser
> Fix For: 1.5.0-incubating
>
> Attachments: wixMavenPluginRefactored.patch
>
>
> I refactored the wix-maven-plugin to:
> * Reduce some duplication
> * Take advantage of the enhanced for loop
> * Simplify the control flow in cases where: if (condition) { throw ... } else { ... }
> can be better expressed as: if (condition) { throw ... } ...
> I also added a couple configuration options: supressSchemaValidation (-ss) & cultures (-cultures)
> I attach the patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (NPANDAY-533) Refactor wix-maven-plugin to reduce
duplication
Posted by "Brett Porter (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter resolved NPANDAY-533.
----------------------------------
Resolution: Fixed
Assignee: Brett Porter
I also had to add a check that cultures was not empty (seems it was string[0]), as IT007 was failing with argument {{-cultures:}}
Does that look right to you?
> Refactor wix-maven-plugin to reduce duplication
> -----------------------------------------------
>
> Key: NPANDAY-533
> URL: https://issues.apache.org/jira/browse/NPANDAY-533
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.5.0-incubating
> Reporter: Adrián Boimvaser
> Assignee: Brett Porter
> Fix For: 1.5.0-incubating
>
> Attachments: wixMavenPluginRefactored.patch
>
>
> I refactored the wix-maven-plugin to:
> * Reduce some duplication
> * Take advantage of the enhanced for loop
> * Simplify the control flow in cases where: if (condition) { throw ... } else { ... }
> can be better expressed as: if (condition) { throw ... } ...
> I also added a couple configuration options: supressSchemaValidation (-ss) & cultures (-cultures)
> I attach the patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (NPANDAY-533) Refactor
wix-maven-plugin to reduce duplication
Posted by "Brett Porter (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188237#comment-13188237 ]
Brett Porter edited comment on NPANDAY-533 at 1/18/12 4:31 AM:
---------------------------------------------------------------
I also had to add a check that cultures was not empty (seems it was string[0]), as IT007 was failing with argument {{-cultures:}}
I also undid the change that did things like {{args.add( "-ext " + ext );}} as it got incorrectly quoted. It should be {{args.add( "-ext" ); args.add( ext ); }} as originally.
Does that look right to you?
was (Author: brettporter):
I also had to add a check that cultures was not empty (seems it was string[0]), as IT007 was failing with argument {{-cultures:}}
Does that look right to you?
> Refactor wix-maven-plugin to reduce duplication
> -----------------------------------------------
>
> Key: NPANDAY-533
> URL: https://issues.apache.org/jira/browse/NPANDAY-533
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.5.0-incubating
> Reporter: Adrián Boimvaser
> Assignee: Brett Porter
> Fix For: 1.5.0-incubating
>
> Attachments: wixMavenPluginRefactored.patch
>
>
> I refactored the wix-maven-plugin to:
> * Reduce some duplication
> * Take advantage of the enhanced for loop
> * Simplify the control flow in cases where: if (condition) { throw ... } else { ... }
> can be better expressed as: if (condition) { throw ... } ...
> I also added a couple configuration options: supressSchemaValidation (-ss) & cultures (-cultures)
> I attach the patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NPANDAY-533) Refactor wix-maven-plugin to
reduce duplication
Posted by "Brett Porter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188205#comment-13188205 ]
Brett Porter commented on NPANDAY-533:
--------------------------------------
applied, thanks! I avoided making most of the formatting changes at the same time, and reformatted as a separate commit (to make the patch easier to review).
> Refactor wix-maven-plugin to reduce duplication
> -----------------------------------------------
>
> Key: NPANDAY-533
> URL: https://issues.apache.org/jira/browse/NPANDAY-533
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.5.0-incubating
> Reporter: Adrián Boimvaser
> Fix For: 1.5.0-incubating
>
> Attachments: wixMavenPluginRefactored.patch
>
>
> I refactored the wix-maven-plugin to:
> * Reduce some duplication
> * Take advantage of the enhanced for loop
> * Simplify the control flow in cases where: if (condition) { throw ... } else { ... }
> can be better expressed as: if (condition) { throw ... } ...
> I also added a couple configuration options: supressSchemaValidation (-ss) & cultures (-cultures)
> I attach the patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NPANDAY-533) Refactor wix-maven-plugin to
reduce duplication
Posted by "Adrián Boimvaser (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NPANDAY-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188456#comment-13188456 ]
Adrián Boimvaser commented on NPANDAY-533:
------------------------------------------
Thanks Brett. I originally did the refactoring before rev 1227173, and then I had to redo it. That's why I missed those details. Also, I didn't know how to run the integration tests.
> Refactor wix-maven-plugin to reduce duplication
> -----------------------------------------------
>
> Key: NPANDAY-533
> URL: https://issues.apache.org/jira/browse/NPANDAY-533
> Project: NPanday
> Issue Type: Improvement
> Components: Maven Plugins
> Affects Versions: 1.5.0-incubating
> Reporter: Adrián Boimvaser
> Assignee: Brett Porter
> Fix For: 1.5.0-incubating
>
> Attachments: wixMavenPluginRefactored.patch
>
>
> I refactored the wix-maven-plugin to:
> * Reduce some duplication
> * Take advantage of the enhanced for loop
> * Simplify the control flow in cases where: if (condition) { throw ... } else { ... }
> can be better expressed as: if (condition) { throw ... } ...
> I also added a couple configuration options: supressSchemaValidation (-ss) & cultures (-cultures)
> I attach the patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira