You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/11 03:43:41 UTC
[GitHub] [hadoop-ozone] ChenSammi opened a new pull request #1054: Hdds 3772. Add LOG to S3ErrorTable for easier problem locating.
ChenSammi opened a new pull request #1054:
URL: https://github.com/apache/hadoop-ozone/pull/1054
https://issues.apache.org/jira/browse/HDDS-3772
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1054: Hdds 3772. Add LOG to S3ErrorTable for easier problem locating.
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #1054:
URL: https://github.com/apache/hadoop-ozone/pull/1054#discussion_r438998025
##########
File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java
##########
@@ -53,15 +54,15 @@ private OzoneAclUtil(){
* @return list of OzoneAcls
* */
public static List<OzoneAcl> getAclList(String userName,
- List<String> userGroups, ACLType userRights, ACLType groupRights) {
+ String[] userGroups, ACLType userRights, ACLType groupRights) {
Review comment:
Is there a particular reason to change from getGroups to getGroupNames(), the later involves list->array->list conversion which can be expensive when large number of groups exist for the user.
##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/exception/S3ErrorTable.java
##########
@@ -29,6 +31,9 @@
*/
public final class S3ErrorTable {
+ private final static Logger LOG = LoggerFactory.getLogger(
+ S3ErrorTable.class);
Review comment:
This seems to be the main part matching scope of the title. Should we use separate tickets to track other changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1054: Hdds 3772. Add LOG to S3ErrorTable for easier problem locating.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on a change in pull request #1054:
URL: https://github.com/apache/hadoop-ozone/pull/1054#discussion_r439211764
##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/exception/S3ErrorTable.java
##########
@@ -106,6 +111,7 @@ public static OS3Exception newError(OS3Exception e, String resource) {
OS3Exception err = new OS3Exception(e.getCode(), e.getErrorMessage(),
e.getHttpCode());
err.setResource(resource);
+ LOG.info(err.toXml());
Review comment:
One comment:
This should be LOG.error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #1054: Hdds 3772. Add LOG to S3ErrorTable for easier problem locating.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on a change in pull request #1054:
URL: https://github.com/apache/hadoop-ozone/pull/1054#discussion_r439177427
##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/exception/S3ErrorTable.java
##########
@@ -29,6 +31,9 @@
*/
public final class S3ErrorTable {
+ private final static Logger LOG = LoggerFactory.getLogger(
+ S3ErrorTable.class);
Review comment:
Sorry, Xiaoyu, I will upload a clean patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter edited a comment on pull request #1054: Hdds 3772. Add LOG to S3ErrorTable for easier problem locating.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1054:
URL: https://github.com/apache/hadoop-ozone/pull/1054#issuecomment-642411148
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=h1) Report
> Merging [#1054](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/cee76a891b21ea50884ad8ba14461b31f60494ea&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `52.27%`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1054 +/- ##
============================================
- Coverage 69.46% 69.33% -0.13%
+ Complexity 9121 9099 -22
============================================
Files 961 961
Lines 48151 48129 -22
Branches 4679 4676 -3
============================================
- Hits 33448 33372 -76
- Misses 12489 12540 +51
- Partials 2214 2217 +3
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...main/java/org/apache/hadoop/ozone/OzoneConsts.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvT3pvbmVDb25zdHMuamF2YQ==) | `84.21% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...apache/hadoop/hdds/utils/db/RocksDBCheckpoint.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy91dGlscy9kYi9Sb2Nrc0RCQ2hlY2twb2ludC5qYXZh) | `90.90% <ø> (+0.90%)` | `5.00 <0.00> (-3.00)` | :arrow_up: |
| [.../java/org/apache/hadoop/ozone/om/OMConfigKeys.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL09NQ29uZmlnS2V5cy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [.../apache/hadoop/ozone/om/OMDBCheckpointServlet.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9PTURCQ2hlY2twb2ludFNlcnZsZXQuamF2YQ==) | `66.26% <ø> (-4.27%)` | `8.00 <0.00> (-2.00)` | |
| [...a/org/apache/hadoop/ozone/om/ha/OMNodeDetails.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9oYS9PTU5vZGVEZXRhaWxzLmphdmE=) | `86.66% <ø> (ø)` | `12.00 <0.00> (ø)` | |
| [...p/ozone/om/ratis/utils/OzoneManagerRatisUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy91dGlscy9Pem9uZU1hbmFnZXJSYXRpc1V0aWxzLmphdmE=) | `67.44% <0.00%> (-19.13%)` | `39.00 <0.00> (ø)` | |
| [.../java/org/apache/hadoop/ozone/om/OzoneManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9Pem9uZU1hbmFnZXIuamF2YQ==) | `64.22% <12.50%> (-0.37%)` | `185.00 <1.00> (-1.00)` | |
| [...adoop/ozone/om/ratis/OzoneManagerStateMachine.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy9Pem9uZU1hbmFnZXJTdGF0ZU1hY2hpbmUuamF2YQ==) | `58.24% <90.47%> (+2.50%)` | `27.00 <4.00> (+1.00)` | |
| [.../apache/hadoop/ozone/om/OmMetadataManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9PbU1ldGFkYXRhTWFuYWdlckltcGwuamF2YQ==) | `82.25% <100.00%> (-0.08%)` | `91.00 <1.00> (ø)` | |
| [...che/hadoop/ozone/om/ratis/OMRatisSnapshotInfo.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy9PTVJhdGlzU25hcHNob3RJbmZvLmphdmE=) | `83.33% <100.00%> (-10.67%)` | `7.00 <1.00> (-5.00)` | |
| ... and [26 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=footer). Last update [78255dd...4340af5](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #1054: Hdds 3772. Add LOG to S3ErrorTable for easier problem locating.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #1054:
URL: https://github.com/apache/hadoop-ozone/pull/1054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1054: Hdds 3772. Add LOG to S3ErrorTable for easier problem locating.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1054:
URL: https://github.com/apache/hadoop-ozone/pull/1054#issuecomment-642411148
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@67244e5`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1054 +/- ##
=========================================
Coverage ? 69.43%
Complexity ? 9113
=========================================
Files ? 961
Lines ? 48150
Branches ? 4679
=========================================
Hits ? 33435
Misses ? 12499
Partials ? 2216
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=footer). Last update [67244e5...06c521d](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter edited a comment on pull request #1054: Hdds 3772. Add LOG to S3ErrorTable for easier problem locating.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1054:
URL: https://github.com/apache/hadoop-ozone/pull/1054#issuecomment-642411148
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=h1) Report
> Merging [#1054](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/cee76a891b21ea50884ad8ba14461b31f60494ea&el=desc) will **decrease** coverage by `0.10%`.
> The diff coverage is `52.27%`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1054 +/- ##
============================================
- Coverage 69.46% 69.35% -0.11%
+ Complexity 9121 9100 -21
============================================
Files 961 961
Lines 48151 48129 -22
Branches 4679 4676 -3
============================================
- Hits 33448 33381 -67
- Misses 12489 12530 +41
- Partials 2214 2218 +4
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...main/java/org/apache/hadoop/ozone/OzoneConsts.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvT3pvbmVDb25zdHMuamF2YQ==) | `84.21% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...apache/hadoop/hdds/utils/db/RocksDBCheckpoint.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy91dGlscy9kYi9Sb2Nrc0RCQ2hlY2twb2ludC5qYXZh) | `90.90% <ø> (+0.90%)` | `5.00 <0.00> (-3.00)` | :arrow_up: |
| [.../java/org/apache/hadoop/ozone/om/OMConfigKeys.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL09NQ29uZmlnS2V5cy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [.../apache/hadoop/ozone/om/OMDBCheckpointServlet.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9PTURCQ2hlY2twb2ludFNlcnZsZXQuamF2YQ==) | `66.26% <ø> (-4.27%)` | `8.00 <0.00> (-2.00)` | |
| [...a/org/apache/hadoop/ozone/om/ha/OMNodeDetails.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9oYS9PTU5vZGVEZXRhaWxzLmphdmE=) | `86.66% <ø> (ø)` | `12.00 <0.00> (ø)` | |
| [...p/ozone/om/ratis/utils/OzoneManagerRatisUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy91dGlscy9Pem9uZU1hbmFnZXJSYXRpc1V0aWxzLmphdmE=) | `67.44% <0.00%> (-19.13%)` | `39.00 <0.00> (ø)` | |
| [.../java/org/apache/hadoop/ozone/om/OzoneManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9Pem9uZU1hbmFnZXIuamF2YQ==) | `64.22% <12.50%> (-0.37%)` | `185.00 <1.00> (-1.00)` | |
| [...adoop/ozone/om/ratis/OzoneManagerStateMachine.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy9Pem9uZU1hbmFnZXJTdGF0ZU1hY2hpbmUuamF2YQ==) | `58.24% <90.47%> (+2.50%)` | `27.00 <4.00> (+1.00)` | |
| [.../apache/hadoop/ozone/om/OmMetadataManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9PbU1ldGFkYXRhTWFuYWdlckltcGwuamF2YQ==) | `82.25% <100.00%> (-0.08%)` | `91.00 <1.00> (ø)` | |
| [...che/hadoop/ozone/om/ratis/OMRatisSnapshotInfo.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy9PTVJhdGlzU25hcHNob3RJbmZvLmphdmE=) | `83.33% <100.00%> (-10.67%)` | `7.00 <1.00> (-5.00)` | |
| ... and [26 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1054/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=footer). Last update [78255dd...d3ff320](https://codecov.io/gh/apache/hadoop-ozone/pull/1054?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1054: Hdds 3772. Add LOG to S3ErrorTable for easier problem locating.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #1054:
URL: https://github.com/apache/hadoop-ozone/pull/1054#issuecomment-643732666
Thank You @ChenSammi for the contribution and @xiaoyuyao for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org