You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/02/23 00:06:17 UTC

[GitHub] mayankshriv commented on a change in pull request #3868: Disable realtime aggregate metrics if multi value dimension present

mayankshriv commented on a change in pull request #3868: Disable realtime aggregate metrics if multi value dimension present
URL: https://github.com/apache/incubator-pinot/pull/3868#discussion_r259549115
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
 ##########
 @@ -715,13 +716,21 @@ private int getOrCreateDocId(Map<String, Object> dictIdMap) {
     }
 
     // All dimension columns should be dictionary encoded.
+    // All dimensions must be single value
     for (String dimension : schema.getDimensionNames()) {
       if (noDictionaryColumns.contains(dimension)) {
         _logger
             .warn("Metrics aggregation cannot be turned ON in presence of no-dictionary dimensions, eg: {}", dimension);
         _aggregateMetrics = false;
         break;
       }
+      // https://github.com/apache/incubator-pinot/issues/3867
+      if (!schema.getDimensionSpec(dimension).isSingleValueField()) {
 
 Review comment:
   This limitation should apply to multi-valued metrics as well, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org