You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/07/15 19:51:10 UTC
Review Request 23490: Add environment test for Docker.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23490/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Yifan Gu.
Bugs: MESOS-1524
https://issues.apache.org/jira/browse/MESOS-1524
Repository: mesos-git
Description
-------
Add environment test for Docker.
The environment validates if docker validation passes before running Docker tests.
Diffs
-----
src/Makefile.am a1fe9dc2173d8e23398edfce6ef7dc458a3c81bb
src/common/status_utils.hpp 19805519efa46f077cdb502d5853f407a6546f67
src/docker/docker.hpp PRE-CREATION
src/docker/docker.cpp PRE-CREATION
src/slave/containerizer/docker.cpp PRE-CREATION
src/tests/docker_containerizer_tests.cpp PRE-CREATION
src/tests/environment.cpp 434b3f7f890ad05c90c88be796996828e0ac4876
Diff: https://reviews.apache.org/r/23490/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 23490: Add environment test for Docker.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23490/
-----------------------------------------------------------
(Updated July 17, 2014, 6:49 p.m.)
Review request for mesos, Benjamin Hindman and Yifan Gu.
Bugs: MESOS-1524
https://issues.apache.org/jira/browse/MESOS-1524
Repository: mesos-git
Description
-------
Add environment test for Docker.
The environment validates if docker validation passes before running Docker tests.
Diffs
-----
src/Makefile.am a1fe9dc2173d8e23398edfce6ef7dc458a3c81bb
src/common/status_utils.hpp 19805519efa46f077cdb502d5853f407a6546f67
src/docker/docker.hpp PRE-CREATION
src/docker/docker.cpp PRE-CREATION
src/slave/containerizer/docker.cpp PRE-CREATION
src/tests/docker_containerizer_tests.cpp PRE-CREATION
src/tests/environment.cpp 434b3f7f890ad05c90c88be796996828e0ac4876
Diff: https://reviews.apache.org/r/23490/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 23490: Add environment test for Docker.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23490/#review47802
-----------------------------------------------------------
Bad patch!
Reviews applied: [23490]
Failed command: git apply --index 23490.patch
Error:
error: src/docker/docker.hpp: does not exist in index
error: src/docker/docker.cpp: does not exist in index
error: src/slave/containerizer/docker.cpp: does not exist in index
- Mesos ReviewBot
On July 15, 2014, 5:51 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23490/
> -----------------------------------------------------------
>
> (Updated July 15, 2014, 5:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Yifan Gu.
>
>
> Bugs: MESOS-1524
> https://issues.apache.org/jira/browse/MESOS-1524
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add environment test for Docker.
>
> The environment validates if docker validation passes before running Docker tests.
>
>
> Diffs
> -----
>
> src/Makefile.am a1fe9dc2173d8e23398edfce6ef7dc458a3c81bb
> src/common/status_utils.hpp 19805519efa46f077cdb502d5853f407a6546f67
> src/docker/docker.hpp PRE-CREATION
> src/docker/docker.cpp PRE-CREATION
> src/slave/containerizer/docker.cpp PRE-CREATION
> src/tests/docker_containerizer_tests.cpp PRE-CREATION
> src/tests/environment.cpp 434b3f7f890ad05c90c88be796996828e0ac4876
>
> Diff: https://reviews.apache.org/r/23490/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>