[GitHub] [knox] pzampino commented on a change in pull request #180: KNOX-2105 - KnoxShell support for token renewal and revocation

[GitBox <gi...@apache.org>]

pzampino commented on a change in pull request #180: KNOX-2105 - KnoxShell support for token renewal and revocation
URL: https://github.com/apache/knox/pull/180#discussion_r343856919
 
 

 ##########
 File path: gateway-shell/src/main/java/org/apache/knox/gateway/shell/ErrorResponse.java
 ##########
 @@ -28,7 +28,7 @@
     this.response = response;
   }
 
-  public HttpResponse getReponse() {
 
 Review comment:
   Actually, I should remove the printing of the stack trace. The call should fail, but is required to setup the actual underlying request (so the setting of the entity can be verified). Short answer: no, it should not fail the test in either case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services