You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/03/14 20:12:00 UTC

[jira] [Work logged] (GOBBLIN-1800) GaaS does not retry SLA killed jobs

     [ https://issues.apache.org/jira/browse/GOBBLIN-1800?focusedWorklogId=850985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-850985 ]

ASF GitHub Bot logged work on GOBBLIN-1800:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Mar/23 20:11
            Start Date: 14/Mar/23 20:11
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request, #3661:
URL: https://github.com/apache/gobblin/pull/3661

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1800
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   
   There are 2 SLAs in GaaS flows:
   1. Job Start SLA, which measures the time in between when GaaS orchestrates a job to when it receives its first event from the job execution. This can catch scenarios such as container bootstrap time taking longer, event emission through Kafka failing, unresponsive executors.
   2. Flow SLA, which measures the e2e time of a flow from start to end. If the job is stuck or taking too long to run past this setting, it fails to save resources on the executor side.
   
   When a user defines `job.maxAttempts` in their GaaS flow, the expected behavior should be that these flows are retried to increase resiliency. 
   
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Added unit tests in `DagManagerFlowTest.java`
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 850985)
    Remaining Estimate: 0h
            Time Spent: 10m

> GaaS does not retry SLA killed jobs
> -----------------------------------
>
>                 Key: GOBBLIN-1800
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1800
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Gobblin-as-a-Service fails jobs when they run past their start SLA and their runtime SLA. It would be expected for jobs to have these SLAs retried if configured to retry, but they currently do not.
> The DagManager should automatically retry jobs that exceed their SLAs if the user configured retries, in case these flow failures are due to intermittent issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)