You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Peter Somogyi via Review Board <no...@reviews.apache.org> on 2018/09/14 13:22:22 UTC
Review Request 68716: SENTRY-2403: Incorrect naming in
RollingFileWithoutDeleteAppender
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68716/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-2403
https://issues.apache.org/jira/browse/SENTRY-2403
Repository: sentry
Description
-------
RollingFileWithoutDeleteAppender incorrectly append timestamp to logfiles without removing previous one.
Diffs
-----
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java fd133f34f
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/log/appender/TestRollingFileWithoutDeleteAppender.java ca9062bca
Diff: https://reviews.apache.org/r/68716/diff/1/
Testing
-------
Modified TestRollingFileWithoutDeleteAppender to check the pattern correctly.
Thanks,
Peter Somogyi
Re: Review Request 68716: SENTRY-2403: Incorrect naming in
RollingFileWithoutDeleteAppender
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68716/#review208706
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Sept. 14, 2018, 1:22 p.m., Peter Somogyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68716/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2018, 1:22 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-2403
> https://issues.apache.org/jira/browse/SENTRY-2403
>
>
> Repository: sentry
>
>
> Description
> -------
>
> RollingFileWithoutDeleteAppender incorrectly append timestamp to logfiles without removing previous one.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java fd133f34f
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/log/appender/TestRollingFileWithoutDeleteAppender.java ca9062bca
>
>
> Diff: https://reviews.apache.org/r/68716/diff/1/
>
>
> Testing
> -------
>
> Modified TestRollingFileWithoutDeleteAppender to check the pattern correctly.
>
>
> Thanks,
>
> Peter Somogyi
>
>