You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/10 05:57:42 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10518: fix(sqllab): Handle long table names in SQL Lab
codecov-commenter edited a comment on pull request #10518:
URL: https://github.com/apache/incubator-superset/pull/10518#issuecomment-671162509
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10518?src=pr&el=h1) Report
> Merging [#10518](https://codecov.io/gh/apache/incubator-superset/pull/10518?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/16459ad401d916d0ce7ca6ffa6775fdcb8a37ae8&el=desc) will **decrease** coverage by `4.63%`.
> The diff coverage is `70.16%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10518?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10518 +/- ##
==========================================
- Coverage 70.74% 66.11% -4.64%
==========================================
Files 604 605 +1
Lines 32391 32421 +30
Branches 3282 3426 +144
==========================================
- Hits 22916 21435 -1481
- Misses 9363 10796 +1433
- Partials 112 190 +78
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.94% <93.33%> (+0.22%)` | :arrow_up: |
| #python | `70.43% <66.97%> (+0.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10518?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10518/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `79.08% <ø> (-5.89%)` | :arrow_down: |
| [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10518/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `14.92% <0.00%> (-2.99%)` | :arrow_down: |
| [...et-frontend/src/views/CRUD/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10518/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YXNldC9EYXRhc2V0TGlzdC50c3g=) | `73.18% <ø> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/10518/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `39.73% <0.00%> (+0.13%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10518/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.86% <0.00%> (+0.47%)` | :arrow_up: |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10518/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <ø> (ø)` | |
| [superset/queries/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10518/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zY2hlbWFzLnB5) | `100.00% <ø> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10518/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `78.69% <0.00%> (+0.77%)` | :arrow_up: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10518/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `93.44% <ø> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10518/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.99% <25.00%> (-0.40%)` | :arrow_down: |
| ... and [189 more](https://codecov.io/gh/apache/incubator-superset/pull/10518/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10518?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10518?src=pr&el=footer). Last update [5bb8b97...29f1a2d](https://codecov.io/gh/apache/incubator-superset/pull/10518?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org