[GitHub] [spark] cxzl25 commented on a diff in pull request #36740: [SPARK-39355][SQL] Avoid UnresolvedAttribute.apply throwing ParseException

[GitBox <gi...@apache.org>]

cxzl25 commented on code in PR #36740:
URL: https://github.com/apache/spark/pull/36740#discussion_r895854783


##########
sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala:
##########
@@ -2176,4 +2176,32 @@ class SubquerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
       }
     }
   }
+
+  test("SPARK-39355: Avoid UnresolvedAttribute.apply throwing ParseException") {
+    checkAnswer(
+      sql("""
+            |SELECT *

Review Comment:
   A `Cast` may be generated `InConversion`, at which time `newSub.output` will call `UnresolvedAttribute.apply`.
   https://github.com/apache/spark/blob/d3d22928d4fca1cd71f96a1308f0cc5d00120ad5/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala#L349-L360



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org