You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/11/05 12:41:34 UTC

[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1076: Fix compiler warning in replication

tisonkun commented on code in PR #1076:
URL: https://github.com/apache/incubator-kvrocks/pull/1076#discussion_r1014630864


##########
src/cluster/replication.cc:
##########
@@ -921,6 +921,9 @@ rocksdb::Status ReplicationThread::ParseWriteBatch(const std::string &batch_stri
       GetFixed64(&entry_id, &id.seq);
       srv_->OnEntryAddedToStream(ikey.GetNamespace().ToString(), ikey.GetKey().ToString(), id);
       break;
+    }
+    default:

Review Comment:
   I don't know whether C++ can resolve exhaustive `case` and we just write `case kBatchTypeNone:` here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org