[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #186: Store offset ranges for parquet files

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #186: Store offset ranges for parquet files
URL: https://github.com/apache/incubator-iceberg/pull/186#discussion_r284562296
 
 

 ##########
 File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetUtil.java
 ##########
 @@ -46,8 +47,9 @@
 
 import static org.apache.iceberg.parquet.ParquetConversions.fromParquetPrimitive;
 
-public class ParquetMetrics implements Serializable {
-  private ParquetMetrics() {
+public class ParquetUtil {
+  // not meant to be instantiated
+  private ParquetUtil() {
   }
 
   public static Metrics fromInputFile(InputFile file) {
 
 Review comment:
   minor point. Since the name of the class is changed, these method names `fromInputFile` and `fromMetadata` seem to be vague

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org