[GitHub] [ozone] mukul1987 commented on a change in pull request #2596: HDDS-5678. Handle unsecure SCM HA converted to secure SCM HA.

[GitBox <gi...@apache.org>]

mukul1987 commented on a change in pull request #2596:
URL: https://github.com/apache/ozone/pull/2596#discussion_r698365202



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -934,6 +946,18 @@ public static boolean scmBootstrap(OzoneConfiguration conf)
                 + "is {}", persistedClusterId, fetchedId);
         return false;
       }
+
+      // Initialize security if security is enabled later.
+      if (OzoneSecurityUtil.isSecurityEnabled(conf)
+          && scmStorageConfig.getScmCertSerialId() == null) {
+        HASecurityUtils.initializeSecurity(scmStorageConfig, conf,

Review comment:
       the two code sections are same, can we move them to a common function ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org