You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Max Timonin <ti...@gmail.com> on 2020/10/08 16:49:22 UTC
Broken test in master: BasicIndexTest
Hi, Igniters!
I was discovering how indexes work and found a failed test.
BasicIndexTest#testInlineSizeChange is broken in master and it's not a
flaky case [1]. But it has been failing since 25/09 only.
I discovered that it happened after the IGNITE-13207 ticket merged
(Checkpointer code refactoring) [2]. I'm not sure about the expected
behaviour of the inline index and how checkpointer affects it. But let's
fix it if it is a bug or completely remove this test.
[1]
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=6131871779633595667&branch=%3Cdefault%3E&tab=testDetails
[2] https://issues.apache.org/jira/browse/IGNITE-13207
Re[2]: Broken test in master: BasicIndexTest
Posted by Zhenya Stanilovsky <ar...@mail.ru.INVALID>.
Of course, i still have no ticket filled. As was discussed in private i will fill other ticket that can lead to potential problems.
>Hi everyone,
>
>I believe I have a fix for this bug - https://issues.apache.org/jira/browse/IGNITE-13500, So Zhenya you can leave this problem to me.
>
>--
>Best regards,
>Anton Kalashnikov
>
>
>
>09.10.2020, 10:19, "Sergey Chugunov" < sergey.chugunov@gmail.com >:
>> Max,
>>
>> Thanks for spotting this, great catch!
>>
>> Zhenya, could you please file a ticket of at least Critical priority?
>>
>> On Fri, Oct 9, 2020 at 9:24 AM Zhenya Stanilovsky
>> < arzamas123@mail.ru.invalid > wrote:
>>
>>> Thanks Maxim, the test is correct no need for removal.
>>> I checked 2.9 too, but looks it all ok there. I will take a look.
>>> >Hi, Igniters!
>>> >
>>> >I was discovering how indexes work and found a failed test.
>>> >BasicIndexTest#testInlineSizeChange is broken in master and it's not a
>>> >flaky case [1]. But it has been failing since 25/09 only.
>>> >
>>> >I discovered that it happened after the IGNITE-13207 ticket merged
>>> >(Checkpointer code refactoring) [2]. I'm not sure about the expected
>>> >behaviour of the inline index and how checkpointer affects it. But let's
>>> >fix it if it is a bug or completely remove this test.
>>> >
>>> >[1]
>>> >
>>> https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=6131871779633595667&branch=%3Cdefault%3E&tab=testDetails
>>> >
>>> >[2] https://issues.apache.org/jira/browse/IGNITE-13207
>>> >
Re: Broken test in master: BasicIndexTest
Posted by Anton Kalashnikov <ka...@yandex.ru>.
Hi everyone,
I believe I have a fix for this bug - https://issues.apache.org/jira/browse/IGNITE-13500, So Zhenya you can leave this problem to me.
--
Best regards,
Anton Kalashnikov
09.10.2020, 10:19, "Sergey Chugunov" <se...@gmail.com>:
> Max,
>
> Thanks for spotting this, great catch!
>
> Zhenya, could you please file a ticket of at least Critical priority?
>
> On Fri, Oct 9, 2020 at 9:24 AM Zhenya Stanilovsky
> <ar...@mail.ru.invalid> wrote:
>
>> Thanks Maxim, the test is correct no need for removal.
>> I checked 2.9 too, but looks it all ok there. I will take a look.
>> >Hi, Igniters!
>> >
>> >I was discovering how indexes work and found a failed test.
>> >BasicIndexTest#testInlineSizeChange is broken in master and it's not a
>> >flaky case [1]. But it has been failing since 25/09 only.
>> >
>> >I discovered that it happened after the IGNITE-13207 ticket merged
>> >(Checkpointer code refactoring) [2]. I'm not sure about the expected
>> >behaviour of the inline index and how checkpointer affects it. But let's
>> >fix it if it is a bug or completely remove this test.
>> >
>> >[1]
>> >
>> https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=6131871779633595667&branch=%3Cdefault%3E&tab=testDetails
>> >
>> >[2] https://issues.apache.org/jira/browse/IGNITE-13207
>> >
Re: Broken test in master: BasicIndexTest
Posted by Sergey Chugunov <se...@gmail.com>.
Max,
Thanks for spotting this, great catch!
Zhenya, could you please file a ticket of at least Critical priority?
On Fri, Oct 9, 2020 at 9:24 AM Zhenya Stanilovsky
<ar...@mail.ru.invalid> wrote:
>
>
> Thanks Maxim, the test is correct no need for removal.
> I checked 2.9 too, but looks it all ok there. I will take a look.
> >Hi, Igniters!
> >
> >I was discovering how indexes work and found a failed test.
> >BasicIndexTest#testInlineSizeChange is broken in master and it's not a
> >flaky case [1]. But it has been failing since 25/09 only.
> >
> >I discovered that it happened after the IGNITE-13207 ticket merged
> >(Checkpointer code refactoring) [2]. I'm not sure about the expected
> >behaviour of the inline index and how checkpointer affects it. But let's
> >fix it if it is a bug or completely remove this test.
> >
> >[1]
> >
> https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=6131871779633595667&branch=%3Cdefault%3E&tab=testDetails
> >
> >[2] https://issues.apache.org/jira/browse/IGNITE-13207
> >
>
Re: Broken test in master: BasicIndexTest
Posted by Zhenya Stanilovsky <ar...@mail.ru.INVALID>.
Thanks Maxim, the test is correct no need for removal.
I checked 2.9 too, but looks it all ok there. I will take a look.
>Hi, Igniters!
>
>I was discovering how indexes work and found a failed test.
>BasicIndexTest#testInlineSizeChange is broken in master and it's not a
>flaky case [1]. But it has been failing since 25/09 only.
>
>I discovered that it happened after the IGNITE-13207 ticket merged
>(Checkpointer code refactoring) [2]. I'm not sure about the expected
>behaviour of the inline index and how checkpointer affects it. But let's
>fix it if it is a bug or completely remove this test.
>
>[1]
>https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=6131871779633595667&branch=%3Cdefault%3E&tab=testDetails
>
>[2] https://issues.apache.org/jira/browse/IGNITE-13207
>