You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/27 11:28:33 UTC
[GitHub] [incubator-eventmesh] rinuaby13 opened a new issue, #1977: [Enhancement] There is no need to use return for a void method
rinuaby13 opened a new issue, #1977:
URL: https://github.com/apache/incubator-eventmesh/issues/1977
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
Located at:java/org/apache/eventmesh/runtime/core/protocol/http/consumer/ConsumerManager.java
lines 293,304,314,327,332,337.
The onChange method is a void method and returns are unnecessary in void function.
### Describe the solution you'd like
Removing unnecessary return statement from the given lines in ConsumerManager.
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] SreeRanjani14 commented on issue #1977: [Enhancement] There is no need to use return for a void method
Posted by GitBox <gi...@apache.org>.
SreeRanjani14 commented on issue #1977:
URL: https://github.com/apache/incubator-eventmesh/issues/1977#issuecomment-1294506434
@rinuaby13 I have raised a PR for this [1990](https://github.com/apache/incubator-eventmesh/pull/1990). Kindly check this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #1977: [Enhancement] There is no need to use return for a void method
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #1977: [Enhancement] There is no need to use return for a void method
URL: https://github.com/apache/incubator-eventmesh/issues/1977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org