You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/08/24 14:09:18 UTC

Review Request 37711: RU: Alter service check order

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37711/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-12863
    https://issues.apache.org/jira/browse/AMBARI-12863


Repository: ambari


Description
-------

HBase service check failed consistently because the HBase Master died as it was trying to write the directory and could not find enough good datanodes.  The service check for HBase was run before the service check for HDFS.  There may be a situation in which we're not giving enough time for all the DN's to come up before the HBase service check is being performed, and if it would make more sense to service check HDFS before we service check HBase due to dependencies.

With that said it feels like the RU service check order should be:
* ZooKeeper
* HDFS
* YARN
* Everything else


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 4fe5e98 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 526efe4 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 2aad30b 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 38622bd 
  ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 7a1d522 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml b4b6663 

Diff: https://reviews.apache.org/r/37711/diff/


Testing
-------

Automated pending.  Manual testing.


Thanks,

Nate Cole


Re: Review Request 37711: RU: Alter service check order

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37711/#review96152
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Aug. 24, 2015, 1:49 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37711/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 1:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-12863
>     https://issues.apache.org/jira/browse/AMBARI-12863
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HBase service check failed consistently because the HBase Master died as it was trying to write the directory and could not find enough good datanodes.  The service check for HBase was run before the service check for HDFS.  There may be a situation in which we're not giving enough time for all the DN's to come up before the HBase service check is being performed, and if it would make more sense to service check HDFS before we service check HBase due to dependencies.
> 
> With that said it feels like the RU service check order should be:
> * ZooKeeper
> * HDFS
> * YARN
> * Everything else
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 4fe5e98 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 526efe4 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 2aad30b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 38622bd 
>   ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 7a1d522 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml b4b6663 
> 
> Diff: https://reviews.apache.org/r/37711/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.  Automated:
> 
> Tests run: 3160, Failures: 0, Errors: 0, Skipped: 25
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:28 min
> [INFO] Finished at: 2015-08-24T09:46:08-04:00
> [INFO] Final Memory: 34M/1554M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 37711: RU: Alter service check order

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37711/
-----------------------------------------------------------

(Updated Aug. 24, 2015, 9:49 a.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Changes
-------

updated test results


Bugs: AMBARI-12863
    https://issues.apache.org/jira/browse/AMBARI-12863


Repository: ambari


Description
-------

HBase service check failed consistently because the HBase Master died as it was trying to write the directory and could not find enough good datanodes.  The service check for HBase was run before the service check for HDFS.  There may be a situation in which we're not giving enough time for all the DN's to come up before the HBase service check is being performed, and if it would make more sense to service check HDFS before we service check HBase due to dependencies.

With that said it feels like the RU service check order should be:
* ZooKeeper
* HDFS
* YARN
* Everything else


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 4fe5e98 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 526efe4 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 2aad30b 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 38622bd 
  ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 7a1d522 
  ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml b4b6663 

Diff: https://reviews.apache.org/r/37711/diff/


Testing (updated)
-------

Manual testing.  Automated:

Tests run: 3160, Failures: 0, Errors: 0, Skipped: 25

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:28 min
[INFO] Finished at: 2015-08-24T09:46:08-04:00
[INFO] Final Memory: 34M/1554M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 37711: RU: Alter service check order

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37711/#review96141
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Aug. 24, 2015, 8:09 a.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37711/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 8:09 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-12863
>     https://issues.apache.org/jira/browse/AMBARI-12863
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HBase service check failed consistently because the HBase Master died as it was trying to write the directory and could not find enough good datanodes.  The service check for HBase was run before the service check for HDFS.  There may be a situation in which we're not giving enough time for all the DN's to come up before the HBase service check is being performed, and if it would make more sense to service check HDFS before we service check HBase due to dependencies.
> 
> With that said it feels like the RU service check order should be:
> * ZooKeeper
> * HDFS
> * YARN
> * Everything else
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java 4fe5e98 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 526efe4 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 2aad30b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 38622bd 
>   ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java 7a1d522 
>   ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml b4b6663 
> 
> Diff: https://reviews.apache.org/r/37711/diff/
> 
> 
> Testing
> -------
> 
> Automated pending.  Manual testing.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>