You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/01 01:26:03 UTC
[GitHub] [spark] maropu commented on a change in pull request #28081:
[SPARK-31315][SQL][TEST] SQLQueryTestSuite: Display the total compile time
for generated java code
maropu commented on a change in pull request #28081: [SPARK-31315][SQL][TEST] SQLQueryTestSuite: Display the total compile time for generated java code
URL: https://github.com/apache/spark/pull/28081#discussion_r401305322
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -667,6 +669,13 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
// For debugging dump some statistics about how much time was spent in various optimizer rules
logWarning(RuleExecutor.dumpTimeSpent())
+
+ val codegenInfo =
+ s"""
+ |=== Metrics of Whole Codegen ===
+ |Total compile time: ${CodeGenerator.compileTime.sum.toDouble / NANOS_PER_SECOND} seconds
Review comment:
Probably, we need to reset this metric in `beforeAll`? btw , could we reuse `CodegenMetrics.METRIC_COMPILATION_TIME` for this purpose? Getting the same metric for the same purpose seems redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org