You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Wei-Chiu Chuang <we...@apache.org> on 2022/08/23 16:51:44 UTC
[DISCUSS] Enable 'squash and merge' in Ambari's github repo
In other projects that I work on, we enforce "squash and merge" when
merging a github PR.
It makes commit history much cleaner, because a PR gets mapped to a single
git commit.
Thoughts on this? I am making this recommendation because in the current
Ambari git repo we end up with several commits.
All it takes is an INFRA jira. I can help raise that jira if folks agree.
[image: Screen Shot 2022-08-23 at 9.41.55 AM.png]
Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
Posted by Jun HE <ju...@apache.org>.
+1.
Battula, Brahma Reddy <bb...@visa.com.invalid> 于2022年8月24日周三 01:44写道：
> One update till this finalized.. Already "squash and Merge" is available
> but it's not default. So, we can select this.
>
>
> On 23/08/22, 10:55 PM, "吴治国" <wz...@163.com> wrote:
>
> +1, A clear commit history is easy for management, thanks Wei-Chiu.
>
> Best Regards,
> Zhiguo Wu
>
> > On Aug 24, 2022, at 01:02, Battula, Brahma Reddy
> <bb...@visa.com.INVALID> wrote:
> >
> >
> > +1, thanks for starting this thread.
> >
> >
> > From: Wei-Chiu Chuang <we...@apache.org>
> > Reply-To: "dev@ambari.apache.org" <de...@ambari.apache.org>
> > Date: Tuesday, 23 August 2022 at 10:22 PM
> > To: "dev@ambari.apache.org" <de...@ambari.apache.org>
> > Subject: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
> >
> > In other projects that I work on, we enforce "squash and merge" when
> merging a github PR.
> >
> > It makes commit history much cleaner, because a PR gets mapped to a
> single git commit.
> >
> > Thoughts on this? I am making this recommendation because in the
> current Ambari git repo we end up with several commits.
> >
> > All it takes is an INFRA jira. I can help raise that jira if folks
> agree.
> >
> > [cid:ii_l76f34z00]
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
> For additional commands, e-mail: dev-help@ambari.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
> For additional commands, e-mail: dev-help@ambari.apache.org
>
>
Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
Posted by "Battula, Brahma Reddy" <bb...@visa.com.INVALID>.
One update till this finalized.. Already "squash and Merge" is available but it's not default. So, we can select this.
On 23/08/22, 10:55 PM, "吴治国" <wz...@163.com> wrote:
+1, A clear commit history is easy for management, thanks Wei-Chiu.
Best Regards,
Zhiguo Wu
> On Aug 24, 2022, at 01:02, Battula, Brahma Reddy <bb...@visa.com.INVALID> wrote:
>
>
> +1, thanks for starting this thread.
>
>
> From: Wei-Chiu Chuang <we...@apache.org>
> Reply-To: "dev@ambari.apache.org" <de...@ambari.apache.org>
> Date: Tuesday, 23 August 2022 at 10:22 PM
> To: "dev@ambari.apache.org" <de...@ambari.apache.org>
> Subject: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
>
> In other projects that I work on, we enforce "squash and merge" when merging a github PR.
>
> It makes commit history much cleaner, because a PR gets mapped to a single git commit.
>
> Thoughts on this? I am making this recommendation because in the current Ambari git repo we end up with several commits.
>
> All it takes is an INFRA jira. I can help raise that jira if folks agree.
>
> [cid:ii_l76f34z00]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
Posted by 吴治国 <wz...@163.com>.
+1, A clear commit history is easy for management, thanks Wei-Chiu.
Best Regards,
Zhiguo Wu
> On Aug 24, 2022, at 01:02, Battula, Brahma Reddy <bb...@visa.com.INVALID> wrote:
>
>
> +1, thanks for starting this thread.
>
>
> From: Wei-Chiu Chuang <we...@apache.org>
> Reply-To: "dev@ambari.apache.org" <de...@ambari.apache.org>
> Date: Tuesday, 23 August 2022 at 10:22 PM
> To: "dev@ambari.apache.org" <de...@ambari.apache.org>
> Subject: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
>
> In other projects that I work on, we enforce "squash and merge" when merging a github PR.
>
> It makes commit history much cleaner, because a PR gets mapped to a single git commit.
>
> Thoughts on this? I am making this recommendation because in the current Ambari git repo we end up with several commits.
>
> All it takes is an INFRA jira. I can help raise that jira if folks agree.
>
> [cid:ii_l76f34z00]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
Posted by "Battula, Brahma Reddy" <bb...@visa.com.INVALID>.
+1, thanks for starting this thread.
From: Wei-Chiu Chuang <we...@apache.org>
Reply-To: "dev@ambari.apache.org" <de...@ambari.apache.org>
Date: Tuesday, 23 August 2022 at 10:22 PM
To: "dev@ambari.apache.org" <de...@ambari.apache.org>
Subject: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
In other projects that I work on, we enforce "squash and merge" when merging a github PR.
It makes commit history much cleaner, because a PR gets mapped to a single git commit.
Thoughts on this? I am making this recommendation because in the current Ambari git repo we end up with several commits.
All it takes is an INFRA jira. I can help raise that jira if folks agree.
[cid:ii_l76f34z00]
Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
Posted by Viraj Jasani <vj...@apache.org>.
Created
https://issues.apache.org/jira/browse/INFRA-23638
Thanks
On Sat, Aug 27, 2022 at 10:42 PM 吴治国 <wz...@163.com> wrote:
> > we can enable autolink redirection from Github
> > commit to Jira for Ambari. I can create similar Infra Jira as
> > https://issues.apache.org/jira/browse/INFRA-21720 for Ambari.
> It will be helpful, thank you Viraj!
> How about we also enable it for Bigtop? @Bigtop Community
>
> Best Regards,
> Zhiguo Wu
>
> > On Aug 27, 2022, at 01:31, Viraj Jasani <vj...@apache.org> wrote:
> >
> > In addition to enabling "squash & merge" as default option, I also think,
> > for the ease of tracking, we can enable autolink redirection from Github
> > commit to Jira for Ambari. I can create similar Infra Jira as
> > https://issues.apache.org/jira/browse/INFRA-21720 for Ambari.
> >
> >
> > On Wed, Aug 24, 2022 at 8:44 AM Viraj Jasani <vj...@apache.org> wrote:
> >
> >> +1 (non-binding) for enforcing squash & merge as default (or only)
> option.
> >>
> >>
> >> On Tue, Aug 23, 2022 at 9:52 AM Wei-Chiu Chuang <we...@apache.org>
> >> wrote:
> >>
> >>> In other projects that I work on, we enforce "squash and merge" when
> >>> merging a github PR.
> >>>
> >>> It makes commit history much cleaner, because a PR gets mapped to a
> >>> single git commit.
> >>>
> >>> Thoughts on this? I am making this recommendation because in the
> current
> >>> Ambari git repo we end up with several commits.
> >>>
> >>> All it takes is an INFRA jira. I can help raise that jira if folks
> agree.
> >>>
> >>> [image: Screen Shot 2022-08-23 at 9.41.55 AM.png]
> >>>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
> For additional commands, e-mail: dev-help@ambari.apache.org
>
>
Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
Posted by 吴治国 <wz...@163.com>.
> we can enable autolink redirection from Github
> commit to Jira for Ambari. I can create similar Infra Jira as
> https://issues.apache.org/jira/browse/INFRA-21720 for Ambari.
It will be helpful, thank you Viraj!
How about we also enable it for Bigtop? @Bigtop Community
Best Regards,
Zhiguo Wu
> On Aug 27, 2022, at 01:31, Viraj Jasani <vj...@apache.org> wrote:
>
> In addition to enabling "squash & merge" as default option, I also think,
> for the ease of tracking, we can enable autolink redirection from Github
> commit to Jira for Ambari. I can create similar Infra Jira as
> https://issues.apache.org/jira/browse/INFRA-21720 for Ambari.
>
>
> On Wed, Aug 24, 2022 at 8:44 AM Viraj Jasani <vj...@apache.org> wrote:
>
>> +1 (non-binding) for enforcing squash & merge as default (or only) option.
>>
>>
>> On Tue, Aug 23, 2022 at 9:52 AM Wei-Chiu Chuang <we...@apache.org>
>> wrote:
>>
>>> In other projects that I work on, we enforce "squash and merge" when
>>> merging a github PR.
>>>
>>> It makes commit history much cleaner, because a PR gets mapped to a
>>> single git commit.
>>>
>>> Thoughts on this? I am making this recommendation because in the current
>>> Ambari git repo we end up with several commits.
>>>
>>> All it takes is an INFRA jira. I can help raise that jira if folks agree.
>>>
>>> [image: Screen Shot 2022-08-23 at 9.41.55 AM.png]
>>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org
Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
Posted by Brahma Reddy Battula <br...@apache.org>.
PR is merged for squash and merge. thanks for wei-chiu.
and after this commit, all comments are going to dev@ambari.apache.org. We
need to add other emails for notifications.
>>we can enable autolink redirection from Github commit to Jira for AmbaI.
It's good to have.
On Fri, Aug 26, 2022 at 11:01 PM Viraj Jasani <vj...@apache.org> wrote:
> In addition to enabling "squash & merge" as default option, I also think,
> for the ease of tracking, we can enable autolink redirection from Github
> commit to Jira for Ambari. I can create similar Infra Jira as
> https://issues.apache.org/jira/browse/INFRA-21720 for Ambari.
>
>
> On Wed, Aug 24, 2022 at 8:44 AM Viraj Jasani <vj...@apache.org> wrote:
>
> > +1 (non-binding) for enforcing squash & merge as default (or only)
> option.
> >
> >
> > On Tue, Aug 23, 2022 at 9:52 AM Wei-Chiu Chuang <we...@apache.org>
> > wrote:
> >
> >> In other projects that I work on, we enforce "squash and merge" when
> >> merging a github PR.
> >>
> >> It makes commit history much cleaner, because a PR gets mapped to a
> >> single git commit.
> >>
> >> Thoughts on this? I am making this recommendation because in the current
> >> Ambari git repo we end up with several commits.
> >>
> >> All it takes is an INFRA jira. I can help raise that jira if folks
> agree.
> >>
> >> [image: Screen Shot 2022-08-23 at 9.41.55 AM.png]
> >>
> >
>
Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
Posted by 吴治国 <wz...@163.com>.
> we can enable autolink redirection from Github
> commit to Jira for Ambari. I can create similar Infra Jira as
> https://issues.apache.org/jira/browse/INFRA-21720 for Ambari.
It will be helpful, thank you Viraj!
How about we also enable it for Bigtop? @Bigtop Community
Best Regards,
Zhiguo Wu
> On Aug 27, 2022, at 01:31, Viraj Jasani <vj...@apache.org> wrote:
>
> In addition to enabling "squash & merge" as default option, I also think,
> for the ease of tracking, we can enable autolink redirection from Github
> commit to Jira for Ambari. I can create similar Infra Jira as
> https://issues.apache.org/jira/browse/INFRA-21720 for Ambari.
>
>
> On Wed, Aug 24, 2022 at 8:44 AM Viraj Jasani <vj...@apache.org> wrote:
>
>> +1 (non-binding) for enforcing squash & merge as default (or only) option.
>>
>>
>> On Tue, Aug 23, 2022 at 9:52 AM Wei-Chiu Chuang <we...@apache.org>
>> wrote:
>>
>>> In other projects that I work on, we enforce "squash and merge" when
>>> merging a github PR.
>>>
>>> It makes commit history much cleaner, because a PR gets mapped to a
>>> single git commit.
>>>
>>> Thoughts on this? I am making this recommendation because in the current
>>> Ambari git repo we end up with several commits.
>>>
>>> All it takes is an INFRA jira. I can help raise that jira if folks agree.
>>>
>>> [image: Screen Shot 2022-08-23 at 9.41.55 AM.png]
>>>
>>
Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
Posted by Viraj Jasani <vj...@apache.org>.
In addition to enabling "squash & merge" as default option, I also think,
for the ease of tracking, we can enable autolink redirection from Github
commit to Jira for Ambari. I can create similar Infra Jira as
https://issues.apache.org/jira/browse/INFRA-21720 for Ambari.
On Wed, Aug 24, 2022 at 8:44 AM Viraj Jasani <vj...@apache.org> wrote:
> +1 (non-binding) for enforcing squash & merge as default (or only) option.
>
>
> On Tue, Aug 23, 2022 at 9:52 AM Wei-Chiu Chuang <we...@apache.org>
> wrote:
>
>> In other projects that I work on, we enforce "squash and merge" when
>> merging a github PR.
>>
>> It makes commit history much cleaner, because a PR gets mapped to a
>> single git commit.
>>
>> Thoughts on this? I am making this recommendation because in the current
>> Ambari git repo we end up with several commits.
>>
>> All it takes is an INFRA jira. I can help raise that jira if folks agree.
>>
>> [image: Screen Shot 2022-08-23 at 9.41.55 AM.png]
>>
>
Re: [DISCUSS] Enable 'squash and merge' in Ambari's github repo
Posted by Viraj Jasani <vj...@apache.org>.
+1 (non-binding) for enforcing squash & merge as default (or only) option.
On Tue, Aug 23, 2022 at 9:52 AM Wei-Chiu Chuang <we...@apache.org> wrote:
> In other projects that I work on, we enforce "squash and merge" when
> merging a github PR.
>
> It makes commit history much cleaner, because a PR gets mapped to a single
> git commit.
>
> Thoughts on this? I am making this recommendation because in the current
> Ambari git repo we end up with several commits.
>
> All it takes is an INFRA jira. I can help raise that jira if folks agree.
>
> [image: Screen Shot 2022-08-23 at 9.41.55 AM.png]
>