You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/25 01:24:21 UTC
Review Request 67305: Moved the "Resource Provider" section to
`resource-provider.md`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67305/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu.
Repository: mesos
Description
-------
The concept of resource providers should have a documentation file
separated from `csi.md`. This patch moves the "Resource Provider"
section from `csi.md` to `resource-provider.md` as a start, and also for
preventing dangling links from other documents.
Diffs
-----
docs/csi.md 9d06da0a4494a7e3bd86e28757846d2ee72efbf3
docs/resource-provider.md PRE-CREATION
Diff: https://reviews.apache.org/r/67305/diff/1/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 67305: Moved the "Resource Provider" section to
`resource-provider.md`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67305/#review203842
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65665', '65666', '67224', '67255', '67256', '67257', '67258', '65112', '67303', '67305']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67305
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67305/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (116 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1066 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (74 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (720 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (745 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (734 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (758 ms total)
[----------] Global test environment tear-down
[==========] 980 tests from 95 test cases ran. (466238 ms total)
[ PASSED ] 979 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
1 FAILED TEST
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67305/logs/mesos-tests-stderr.log):
```
I0525 03:08:57.808288 560 executor.cpp:178] Received SUBSCRIBED event
I0525 03:08:57.813287 560 executor.cpp:182] Subscribed executor on windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0525 03:08:57.813287 560 executor.cpp:178] Received LAUNCH event
I0525 03:08:57.819286 560 executor.cpp:665] Starting task 6f1a2580-36c8-493d-9a39-d323907db796
I0525 03:08:57.898289 560 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0525 03:08:57.916298 560 executor.cpp:678] Forked command at 21036
I0525 03:08:57.946274 21540 exec.cpp:445] Executor asked to shutdown
I0525 03:08:57.946274 16664 executor.cpp:178] Received SHUTDOWN event
I0525 03:08:57.946274 16664 executor.cpp:781] Shutting down
I0525 03:08:57.946274 16664 executor.cpp:894] Sending SIGTERM to process tree at pid 215a2-4911-a96b-ba2fc2dd5830@192.10.1.5:60876
I0525 03:08:57.944304 11300 hierarchical.cpp:405] Deactivated framework e74ce81d-a387-431a-a1c7-d171181577f9-0000
I0525 03:08:57.944304 20664 slave.cpp:3935] Shutting down framework e74ce81d-a387-431a-a1c7-d171181577f9-0000
I0525 03:08:57.944304 8084 master.cpp:10843] Updating the state of task 6f1a2580-36c8-493d-9a39-d323907db796 of framework e74ce81d-a387-431a-a1c7-d171181577f9-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0525 03:08:57.944304 20664 slave.cpp:6656] Shutting down executor '6f1a2580-36c8-493d-9a39-d323907db796' of framework e74ce81d-a387-431a-a1c7-d171181577f9-0000 at executor(1)@192.10.1.5:60897
I0525 03:08:57.946274 20664 slave.cpp:929] Agent terminating
W0525 03:08:57.946274 20664 slave.cpp:3931] Ignoring shutdown framework e74ce81d-a387-431a-a1c7-d171181577f9-0000 because it is terminating
I0525 03:08:57.947273 8084 master.cpp:10942] Removing task 6f1a2580-36c8-493d-9a39-d323907db796 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework e74ce81d-a387-431a-a1c7-d171181577f9-0000 on agent e74ce81d-a387-431a-a1c7-d171181577f9-S0 at slave(447)@192.10.1.5:60876 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 03:08:57.950259 8084 master.cpp:1293] Agent e74ce81d-a387-431a-a1c7-d171181577f9-S0 at slave(447)@192.10.1.5:60876 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0525 03:08:57.950259 8084 master.cpp:3303] Disconnecting agent e74ce81d-a387-431a-a1c7-d171181577f9-S0 at slave(447)@192.10.1.5:60876 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 03:08:57.950259 8084 master.cpp:3322] Deactivating agent e74ce81d-a387-431a-a1c7-d171181577f9-S0 at slave(447)@192.10.1.5:60876 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0525 03:08:57.950259 14576 containerizer.cpp:2404] Destroying container 1e633106-bfdc-442b-a621-1c74fec2d0c6 in RUNNING state
I0525 03:08:57.951274 14576 containerizer.cpp:3018] Transitioning the state of container 1e633106-bfdc-442b-a621-1c74fec2d0c6 from RUNNING to DESTROYING
I0525 03:08:57.951274 19040 hierarchical.cpp:344] Removed framework e74ce81d-a387-431a-a1c7-d171181577f9-0000
I0525 03:08:57.951274 19040 hierarchical.cpp:766] Agent e74ce81d-a387-431a-a1c7-d171181577f9-S0 deactivated
I0525 03:08:57.952299 14576 launcher.cpp:156] Asked to destroy container 1e633106-bfdc-442b-a621-1c74fec2d0c6
I0525 03:08:57.985276 17396 containerizer.cpp:2857] Container 1e633106-bfdc-442b-a621-1c74fec2d0c6 has exited
I0525 03:08:58.015368 11300 master.cpp:1135] Master terminating
I0525 03:08:58.017283 22120 hierarchical.cpp:609] Removed agent e74ce81d-a387-431a-a1c7-d171181577f9-S0
I0525 03:08:58.554059 22716 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On May 25, 2018, 1:24 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67305/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 1:24 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The concept of resource providers should have a documentation file
> separated from `csi.md`. This patch moves the "Resource Provider"
> section from `csi.md` to `resource-provider.md` as a start, and also for
> preventing dangling links from other documents.
>
>
> Diffs
> -----
>
> docs/csi.md 9d06da0a4494a7e3bd86e28757846d2ee72efbf3
> docs/resource-provider.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67305/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67305: Moved the "Resource Provider" section to
`resource-provider.md`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67305/#review204157
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 25, 2018, 1:24 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67305/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 1:24 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The concept of resource providers should have a documentation file
> separated from `csi.md`. This patch moves the "Resource Provider"
> section from `csi.md` to `resource-provider.md` as a start, and also for
> preventing dangling links from other documents.
>
>
> Diffs
> -----
>
> docs/csi.md 9d06da0a4494a7e3bd86e28757846d2ee72efbf3
> docs/resource-provider.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67305/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 67305: Moved the "Resource Provider" section to
`resource-provider.md`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67305/#review203859
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65665, 65666, 67224, 67255, 67256, 67257, 67258, 65112, 67303, 67305]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 25, 2018, 1:24 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67305/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 1:24 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The concept of resource providers should have a documentation file
> separated from `csi.md`. This patch moves the "Resource Provider"
> section from `csi.md` to `resource-provider.md` as a start, and also for
> preventing dangling links from other documents.
>
>
> Diffs
> -----
>
> docs/csi.md 9d06da0a4494a7e3bd86e28757846d2ee72efbf3
> docs/resource-provider.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67305/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>