You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/14 07:21:01 UTC
[GitHub] [airflow] mik-laj opened a new pull request #14224: Allow your own Docker production image to be verified by bash script
mik-laj opened a new pull request #14224:
URL: https://github.com/apache/airflow/pull/14224
I wanted to verify my own image with this script, but I got lost about how to configure the environment variables. For this reason, I would like to split this script into two scripts: one script that is well integrated with our CI environment, and the other that allows us to define our own image and is therefore more user-friendly.
Additionally, I made some other minor changes:
- All tests are always run, but if one check fails, the script fails.
- Rename some functions: check_feature -> check_command, verify_production_image_features -> verify_production_image_python_modules
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14224: Allow your own Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-778758924
Static checks failing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14224: Allow your own Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-778740501
Also (at least for now), breeze is the entrypoint for all useful user commands (it is better for discovery rather than having separate scripts), so it would be good to run it as command in breeze. This is not needed in this PR though but I can add it once we have the shared libraries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow your own Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-778768708
[The Workflow run](https://github.com/apache/airflow/actions/runs/565831561) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow your own Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-778742406
[The Workflow run](https://github.com/apache/airflow/actions/runs/565459117) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #14224: Allow your own Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-778742609
> Also (at least for now), breeze is the entrypoint for all useful user commands (it is better for discovery rather than having separate scripts), so it would be good to run it as command in breeze. This is not needed in this PR though but I can add it once we have the shared libraries.
Unfortunately, my skills do not allow for contributions to the ./breeze script. Unfortunately, there are too many Bash and too many global variables out there to be comfortable for me. I created a new script `/scripts/ci/tools/verify_docker_image.sh` and I hope it will be a good enough solution for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #14224: Allow custom Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #14224:
URL: https://github.com/apache/airflow/pull/14224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow your own Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-778747349
[The Workflow run](https://github.com/apache/airflow/actions/runs/565535010) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow your own Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-778747384
[The Workflow run](https://github.com/apache/airflow/actions/runs/565494081) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow custom Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-782372060
[The Workflow run](https://github.com/apache/airflow/actions/runs/582719357) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow custom Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-782373821
[The Workflow run](https://github.com/apache/airflow/actions/runs/582732341) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14224: Allow your own Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-778743277
> Unfortunately, my skills do not allow for contributions to the ./breeze script. Unfortunately, there are too many Bash and too many global variables out there to be comfortable for me. I created a new script `/scripts/ci/tools/verify_docker_image.sh` and I hope it will be a good enough solution for now.
It's rather easy following other commands, but this is no problem. I can add it once this one is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow custom Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-779694652
[The Workflow run](https://github.com/apache/airflow/actions/runs/571089410) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow custom Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-782619089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow custom Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-781598880
[The Workflow run](https://github.com/apache/airflow/actions/runs/579278314) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow your own Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-778743406
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow custom Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-782371983
[The Workflow run](https://github.com/apache/airflow/actions/runs/582719326) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14224: Allow custom Docker production image to be verified by bash script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14224:
URL: https://github.com/apache/airflow/pull/14224#issuecomment-782300901
[The Workflow run](https://github.com/apache/airflow/actions/runs/582489077) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org