You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "dermasmid (via GitHub)" <gi...@apache.org> on 2024/01/03 14:57:49 UTC
[PR] update node image to 18 and use slim [beam]
dermasmid opened a new pull request, #29903:
URL: https://github.com/apache/beam/pull/29903
Draft
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29903:
URL: https://github.com/apache/beam/pull/29903#issuecomment-1883292171
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @ahmedabu98 for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb merged PR #29903:
URL: https://github.com/apache/beam/pull/29903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #29903:
URL: https://github.com/apache/beam/pull/29903#issuecomment-1883289894
assign to next reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on code in PR #29903:
URL: https://github.com/apache/beam/pull/29903#discussion_r1447748317
##########
sdks/typescript/build.sh:
##########
@@ -22,9 +22,6 @@
set -e
-# Make the packaging version available to the code.
-echo "export const version = \"$npm_package_version\";" > src/apache_beam/version.ts
-
# Using npx to execute ttsc from the local node_modules environment.
npx ttsc -p .
Review Comment:
Now that we're down to a single command, how about removing build.sh and just putting this `ttsc` call in package.json directly?
##########
sdks/typescript/build.sh:
##########
@@ -22,9 +22,6 @@
set -e
-# Make the packaging version available to the code.
Review Comment:
Thanks! I couldn't figure out how to do this myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "dermasmid (via GitHub)" <gi...@apache.org>.
dermasmid commented on code in PR #29903:
URL: https://github.com/apache/beam/pull/29903#discussion_r1447807679
##########
sdks/typescript/src/apache_beam/worker/worker_main.ts:
##########
@@ -64,10 +64,10 @@ async function main() {
},
options,
);
+ console.info("Worker started.");
Review Comment:
The await for the logs blocks, so I didn't get the started log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on code in PR #29903:
URL: https://github.com/apache/beam/pull/29903#discussion_r1447774031
##########
sdks/typescript/src/apache_beam/worker/worker_main.ts:
##########
@@ -64,10 +64,10 @@ async function main() {
},
options,
);
+ console.info("Worker started.");
Review Comment:
Why did you move this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "robertwb (via GitHub)" <gi...@apache.org>.
robertwb commented on code in PR #29903:
URL: https://github.com/apache/beam/pull/29903#discussion_r1447838573
##########
sdks/typescript/src/apache_beam/worker/worker_main.ts:
##########
@@ -64,10 +64,10 @@ async function main() {
},
options,
);
+ console.info("Worker started.");
Review Comment:
Oh, yes. I suppose the intent is to "start this in the background." Not sure the idiomatic way to do this, but the change is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Typescript Worker improvements [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #29903:
URL: https://github.com/apache/beam/pull/29903#issuecomment-1877805657
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/29903?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`6751a17`)](https://app.codecov.io/gh/apache/beam/commit/6751a1737c19d7022c30e850a718e73cd1909e30?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 38.24% compared to head [(`59437e8`)](https://app.codecov.io/gh/apache/beam/pull/29903?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 38.23%.
> Report is 19 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #29903 +/- ##
==========================================
- Coverage 38.24% 38.23% -0.02%
==========================================
Files 696 696
Lines 101881 101881
==========================================
- Hits 38963 38950 -13
- Misses 61306 61313 +7
- Partials 1612 1618 +6
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/29903/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [go](https://app.codecov.io/gh/apache/beam/pull/29903/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.92% <ø> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/29903?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29903:
URL: https://github.com/apache/beam/pull/29903#issuecomment-1883330912
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damondouglas for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #29903:
URL: https://github.com/apache/beam/pull/29903#issuecomment-1883327886
assign to next reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #29903:
URL: https://github.com/apache/beam/pull/29903#issuecomment-1883290394
I'm not familiar with TS, so I'm not a good reviewer for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29903:
URL: https://github.com/apache/beam/pull/29903#issuecomment-1877823749
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @johnjcasey for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #29903:
URL: https://github.com/apache/beam/pull/29903#issuecomment-1883328483
CC @robertwb who is more familiar with TS SDK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "dermasmid (via GitHub)" <gi...@apache.org>.
dermasmid commented on code in PR #29903:
URL: https://github.com/apache/beam/pull/29903#discussion_r1447808434
##########
sdks/typescript/build.sh:
##########
@@ -22,9 +22,6 @@
set -e
-# Make the packaging version available to the code.
-echo "export const version = \"$npm_package_version\";" > src/apache_beam/version.ts
-
# Using npx to execute ttsc from the local node_modules environment.
npx ttsc -p .
Review Comment:
I'll work on that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Typescript] Worker improvements [beam]
Posted by "dermasmid (via GitHub)" <gi...@apache.org>.
dermasmid commented on code in PR #29903:
URL: https://github.com/apache/beam/pull/29903#discussion_r1447846958
##########
sdks/typescript/src/apache_beam/worker/worker_main.ts:
##########
@@ -64,10 +64,10 @@ async function main() {
},
options,
);
+ console.info("Worker started.");
Review Comment:
We could remove the await on the logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org