You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nikhil P <np...@gmail.com> on 2018/08/06 11:02:37 UTC
Review Request 68228: Unit Test cases to cover policy operations from
service admin user
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68228/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2171
https://issues.apache.org/jira/browse/RANGER-2171
Repository: ranger
Description
-------
Unit Test cases to cover policy operations from service admin user(RANGER-2168)
Diffs
-----
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java b0b0110
Diff: https://reviews.apache.org/r/68228/diff/1/
Testing
-------
Tested if unit test cases are running fine on local.
Thanks,
Nikhil P
Re: Review Request 68228: Unit Test cases to cover policy operations
from service admin user
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68228/#review206883
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Aug. 6, 2018, 11:02 a.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68228/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2018, 11:02 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2171
> https://issues.apache.org/jira/browse/RANGER-2171
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Unit Test cases to cover policy operations from service admin user(RANGER-2168)
>
>
> Diffs
> -----
>
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java b0b0110
>
>
> Diff: https://reviews.apache.org/r/68228/diff/1/
>
>
> Testing
> -------
>
> Tested if unit test cases are running fine on local.
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 68228: Unit Test cases to cover policy operations
from service admin user
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68228/#review206944
-----------------------------------------------------------
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java
Lines 1046 (patched)
<https://reviews.apache.org/r/68228/#comment290122>
Can you fix the PMD error? This is breaking the build?
```
[INFO] --- maven-pmd-plugin:3.7:check (default) @ security-admin-web ---
[INFO] PMD Failure: org.apache.ranger.rest.TestServiceREST:1046 Rule:UnusedLocalVariable Priority:3 Avoid unused local variables such as 'rs'..
```
- Velmurugan Periasamy
On Aug. 7, 2018, 7:26 a.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68228/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 7:26 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2171
> https://issues.apache.org/jira/browse/RANGER-2171
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Unit Test cases to cover policy operations from service admin user(RANGER-2168)
>
>
> Diffs
> -----
>
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java b0b0110
> security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java e669c03
>
>
> Diff: https://reviews.apache.org/r/68228/diff/2/
>
>
> Testing
> -------
>
> Tested if unit test cases are running fine on local.
>
>
> File Attachments
> ----------------
>
> RANGER-2171_2.patch
> https://reviews.apache.org/media/uploaded/files/2018/08/07/a83485c8-19f4-428c-b145-d271a16916f8__RANGER-2171_2.patch
> RANGER-2171_2.patch
> https://reviews.apache.org/media/uploaded/files/2018/08/07/4897e7a7-d3c0-46c0-b223-92c26eda5060__RANGER-2171_2.patch
> RANGER-2171_2.patch
> https://reviews.apache.org/media/uploaded/files/2018/08/07/81cec758-8870-4ebf-89f0-3f621a862dc9__RANGER-2171_2.patch
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 68228: Unit Test cases to cover policy operations
from service admin user
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68228/#review206935
-----------------------------------------------------------
Ship it!
Ship It!
- Gautam Borad
On Aug. 7, 2018, 7:26 a.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68228/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 7:26 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2171
> https://issues.apache.org/jira/browse/RANGER-2171
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Unit Test cases to cover policy operations from service admin user(RANGER-2168)
>
>
> Diffs
> -----
>
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java b0b0110
> security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java e669c03
>
>
> Diff: https://reviews.apache.org/r/68228/diff/2/
>
>
> Testing
> -------
>
> Tested if unit test cases are running fine on local.
>
>
> File Attachments
> ----------------
>
> RANGER-2171_2.patch
> https://reviews.apache.org/media/uploaded/files/2018/08/07/a83485c8-19f4-428c-b145-d271a16916f8__RANGER-2171_2.patch
> RANGER-2171_2.patch
> https://reviews.apache.org/media/uploaded/files/2018/08/07/4897e7a7-d3c0-46c0-b223-92c26eda5060__RANGER-2171_2.patch
> RANGER-2171_2.patch
> https://reviews.apache.org/media/uploaded/files/2018/08/07/81cec758-8870-4ebf-89f0-3f621a862dc9__RANGER-2171_2.patch
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 68228: Unit Test cases to cover policy operations
from service admin user
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68228/#review206936
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Aug. 7, 2018, 7:26 a.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68228/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 7:26 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2171
> https://issues.apache.org/jira/browse/RANGER-2171
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Unit Test cases to cover policy operations from service admin user(RANGER-2168)
>
>
> Diffs
> -----
>
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java b0b0110
> security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java e669c03
>
>
> Diff: https://reviews.apache.org/r/68228/diff/2/
>
>
> Testing
> -------
>
> Tested if unit test cases are running fine on local.
>
>
> File Attachments
> ----------------
>
> RANGER-2171_2.patch
> https://reviews.apache.org/media/uploaded/files/2018/08/07/a83485c8-19f4-428c-b145-d271a16916f8__RANGER-2171_2.patch
> RANGER-2171_2.patch
> https://reviews.apache.org/media/uploaded/files/2018/08/07/4897e7a7-d3c0-46c0-b223-92c26eda5060__RANGER-2171_2.patch
> RANGER-2171_2.patch
> https://reviews.apache.org/media/uploaded/files/2018/08/07/81cec758-8870-4ebf-89f0-3f621a862dc9__RANGER-2171_2.patch
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 68228: Unit Test cases to cover policy operations
from service admin user
Posted by Nikhil P <np...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68228/
-----------------------------------------------------------
(Updated Aug. 7, 2018, 12:56 p.m.)
Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2171
https://issues.apache.org/jira/browse/RANGER-2171
Repository: ranger
Description
-------
Unit Test cases to cover policy operations from service admin user(RANGER-2168)
Diffs (updated)
-----
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java b0b0110
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java e669c03
Diff: https://reviews.apache.org/r/68228/diff/2/
Changes: https://reviews.apache.org/r/68228/diff/1-2/
Testing
-------
Tested if unit test cases are running fine on local.
File Attachments (updated)
----------------
RANGER-2171_2.patch
https://reviews.apache.org/media/uploaded/files/2018/08/07/a83485c8-19f4-428c-b145-d271a16916f8__RANGER-2171_2.patch
RANGER-2171_2.patch
https://reviews.apache.org/media/uploaded/files/2018/08/07/4897e7a7-d3c0-46c0-b223-92c26eda5060__RANGER-2171_2.patch
RANGER-2171_2.patch
https://reviews.apache.org/media/uploaded/files/2018/08/07/81cec758-8870-4ebf-89f0-3f621a862dc9__RANGER-2171_2.patch
Thanks,
Nikhil P