You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:48:38 UTC
[GitHub] [spark] zero323 opened a new pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
zero323 opened a new pull request #34296:
URL: https://github.com/apache/spark/pull/34296
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR:
- Adds basic data test runner to `dev/lint-python`, using [`typeddjango/pytest-mypy-plugins`](https://github.com/typeddjango/pytest-mypy-plugins)
- Migrates data test cases from `pyspark-stubs`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently, type annotations are tested primarily for integrity and, to lesser extent, against actual API. Testing against examples is work in progress (SPARK-36997). Data tests allow us to improve coverage and test negative cases (code, that should fail type checker validation).
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Running linter tests with additions proposed in this PR>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34296:
URL: https://github.com/apache/spark/pull/34296#discussion_r733087612
##########
File path: python/pyproject.toml
##########
@@ -0,0 +1,25 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+[tool.pytest.ini_options]
+# Pytest it used only to run mypy data tests
+python_files = "test_*.yml"
+testpaths = [
+ "pyspark/tests/typing",
+ "pyspark/sql/tests/typing",
+ "pyspark/ml/typing",
+]
Review comment:
Should `config` be placed in `python` or in `dev` (we already have `dev/tox.ini` and `python/mypy.ini`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948066134
**[Test build #144472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144472/testReport)** for PR 34296 at commit [`d3a05f9`](https://github.com/apache/spark/commit/d3a05f97e3ea5aaf8b311237aca782d1d6a7b5e0).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-947981923
**[Test build #144472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144472/testReport)** for PR 34296 at commit [`d3a05f9`](https://github.com/apache/spark/commit/d3a05f97e3ea5aaf8b311237aca782d1d6a7b5e0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950000966
**[Test build #144548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144548/testReport)** for PR 34296 at commit [`cf8e27c`](https://github.com/apache/spark/commit/cf8e27c53efd6623ed7a1dfa6fa7068c5cc98678).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-947981923
**[Test build #144472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144472/testReport)** for PR 34296 at commit [`d3a05f9`](https://github.com/apache/spark/commit/d3a05f97e3ea5aaf8b311237aca782d1d6a7b5e0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950029774
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49019/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950014277
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49019/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945718811
**[Test build #144371 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144371/testReport)** for PR 34296 at commit [`62018ce`](https://github.com/apache/spark/commit/62018ce594a02b19747595a25df4be9b8e571bfd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-946031519
**[Test build #144374 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144374/testReport)** for PR 34296 at commit [`13ad5e3`](https://github.com/apache/spark/commit/13ad5e3287e5eff221570fa705d546c189aa1254).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945096241
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48810/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945772032
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48846/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950026540
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49019/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950156554
**[Test build #144556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144556/testReport)** for PR 34296 at commit [`d7bb84b`](https://github.com/apache/spark/commit/d7bb84b30d3f37658bd20887bf8f3aeb9dea4cb0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950180352
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144556/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948776672
**[Test build #144508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144508/testReport)** for PR 34296 at commit [`cf13fbb`](https://github.com/apache/spark/commit/cf13fbbaa56cc3a37777062d1f14017a8ed68b66).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950152345
**[Test build #144554 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144554/testReport)** for PR 34296 at commit [`014e316`](https://github.com/apache/spark/commit/014e316c5206afe66e0ef0da0a044c0d1e0a03e7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34296:
URL: https://github.com/apache/spark/pull/34296#discussion_r733088786
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -442,6 +442,8 @@ jobs:
# Jinja2 3.0.0+ causes error when building with Sphinx.
# See also https://issues.apache.org/jira/browse/SPARK-35375.
python3.9 -m pip install flake8 pydata_sphinx_theme 'mypy==0.910' numpydoc 'jinja2<3.0.0' 'black==21.5b2'
+ # TODO Update to PyPI
+ python3.9 -m pip install git+https://github.com/typeddjango/pytest-mypy-plugins.git@1ad40a97b70c4e15410adf72eed41fbeef69ff45
Review comment:
For now, it is better to install directly from GitHub and wait for typeddjango/pytest-mypy-plugins#85 to be released. It doesn't affect us directly here, but might be pain in local development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950202573
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49031/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950222851
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144560/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948014870
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48945/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948632459
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144504/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950141060
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144553/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34296:
URL: https://github.com/apache/spark/pull/34296#discussion_r729984032
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -442,6 +442,8 @@ jobs:
# Jinja2 3.0.0+ causes error when building with Sphinx.
# See also https://issues.apache.org/jira/browse/SPARK-35375.
python3.9 -m pip install flake8 pydata_sphinx_theme 'mypy==0.910' numpydoc 'jinja2<3.0.0' 'black==21.5b2'
+ # TODO Update to PyPI
+ python3.9 -m pip install git+https://github.com/typeddjango/pytest-mypy-plugins.git@0d790e7a92292da20dcafded1c5b1d637a22b0da
Review comment:
At minimum, we need 1.9.2 (https://github.com/typeddjango/pytest-mypy-plugins/issues/78), but I'll keep monitoring the situation and see if anything else pops up during the migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-944442128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950000966
**[Test build #144548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144548/testReport)** for PR 34296 at commit [`cf8e27c`](https://github.com/apache/spark/commit/cf8e27c53efd6623ed7a1dfa6fa7068c5cc98678).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950196740
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49029/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950136549
**[Test build #144553 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144553/testReport)** for PR 34296 at commit [`cc3c8f9`](https://github.com/apache/spark/commit/cc3c8f94c7f7b57ddd8a0ee4e103a63b0766b870).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950177663
**[Test build #144556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144556/testReport)** for PR 34296 at commit [`d7bb84b`](https://github.com/apache/spark/commit/d7bb84b30d3f37658bd20887bf8f3aeb9dea4cb0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950188823
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49028/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950156074
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144554/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950172264
**[Test build #144557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144557/testReport)** for PR 34296 at commit [`b3e3f25`](https://github.com/apache/spark/commit/b3e3f257d6add7097bb37ff1744efadde774990c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-944837477
thanks @zero323 for working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945096440
**[Test build #144331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144331/testReport)** for PR 34296 at commit [`149996e`](https://github.com/apache/spark/commit/149996ee88395d290af1b75532a3fe24254be124).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945947388
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48848/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945718811
**[Test build #144371 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144371/testReport)** for PR 34296 at commit [`62018ce`](https://github.com/apache/spark/commit/62018ce594a02b19747595a25df4be9b8e571bfd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-947625321
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144457/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945839308
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48846/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948067194
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144472/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-947545962
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48930/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-947582406
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48930/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950121535
**[Test build #144553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144553/testReport)** for PR 34296 at commit [`cc3c8f9`](https://github.com/apache/spark/commit/cc3c8f94c7f7b57ddd8a0ee4e103a63b0766b870).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950197317
**[Test build #144560 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144560/testReport)** for PR 34296 at commit [`e052edc`](https://github.com/apache/spark/commit/e052edcd10712e604bd20c25db236f6fdb673d28).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950126221
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49024/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950179087
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49028/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950180352
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144556/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948057690
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48945/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948067194
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144472/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945096440
**[Test build #144331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144331/testReport)** for PR 34296 at commit [`149996e`](https://github.com/apache/spark/commit/149996ee88395d290af1b75532a3fe24254be124).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-944442128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-946002267
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48848/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945108560
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48810/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948660449
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48979/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948690506
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48979/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948635526
**[Test build #144508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144508/testReport)** for PR 34296 at commit [`cf13fbb`](https://github.com/apache/spark/commit/cf13fbbaa56cc3a37777062d1f14017a8ed68b66).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945898607
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-946050801
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144374/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34296:
URL: https://github.com/apache/spark/pull/34296#discussion_r734874865
##########
File path: dev/lint-python
##########
@@ -124,39 +125,76 @@ function pycodestyle_test {
fi
}
-function mypy_test {
- local MYPY_REPORT=
- local MYPY_STATUS=
- if ! hash "$MYPY_BUILD" 2> /dev/null; then
- echo "The $MYPY_BUILD command was not found. Skipping for now."
- return
+function mypy_annotation_test {
Review comment:
Yes, that's correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950038360
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144548/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950121535
**[Test build #144553 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144553/testReport)** for PR 34296 at commit [`cc3c8f9`](https://github.com/apache/spark/commit/cc3c8f94c7f7b57ddd8a0ee4e103a63b0766b870).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950121617
> Hmm, seems like the new checks are not working?
Yeah, I've seen this, but for earth cannot figure out wgt
> Hmm, seems like the new checks are not working?
>
> ```
> starting mypy data test...
> pytest-mypy-plugins missing. Skipping for now.
> ```
>
> https://github.com/zero323/spark/runs/3981009798?check_suite_focus=true
Yeah, I've seen but still have no idea why this happens. Plugin seems to install correctly, so it should be visible by pip.
I'll try another approach and see if it does the trick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950134359
**[Test build #144554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144554/testReport)** for PR 34296 at commit [`014e316`](https://github.com/apache/spark/commit/014e316c5206afe66e0ef0da0a044c0d1e0a03e7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950167378
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49027/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950193461
**[Test build #144557 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144557/testReport)** for PR 34296 at commit [`b3e3f25`](https://github.com/apache/spark/commit/b3e3f257d6add7097bb37ff1744efadde774990c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950213756
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49031/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945108560
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48810/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950029774
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49019/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950038360
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144548/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950196873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945103997
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48810/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945130535
**[Test build #144331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144331/testReport)** for PR 34296 at commit [`149996e`](https://github.com/apache/spark/commit/149996ee88395d290af1b75532a3fe24254be124).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` class Foo(Params):`
* ` class Bar(Params):`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945839308
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48846/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945819194
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48846/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945898607
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34296:
URL: https://github.com/apache/spark/pull/34296#discussion_r733086374
##########
File path: python/pyproject.toml
##########
@@ -0,0 +1,25 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+[tool.pytest.ini_options]
+# Pytest it used only to run mypy data tests
+python_files = "test_*.yml"
+testpaths = [
+ "pyspark/tests/typing",
+ "pyspark/sql/tests/typing",
+ "pyspark/ml/typing",
+]
Review comment:
Should config live in `python/pyspark` or rather in `dev`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948041311
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48945/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948579161
**[Test build #144507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144507/testReport)** for PR 34296 at commit [`714cb43`](https://github.com/apache/spark/commit/714cb43dc39d0bde5b920f66aee0f5772fc281d3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948621171
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48979/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948715595
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48980/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-947582406
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48930/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948526591
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48976/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-947621712
**[Test build #144457 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144457/testReport)** for PR 34296 at commit [`d3d3755`](https://github.com/apache/spark/commit/d3d375504b8ec502d917011ede43ac9f78e1bb44).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-946002267
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48848/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948578406
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48976/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950156074
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144554/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948740705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948722451
**[Test build #144507 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144507/testReport)** for PR 34296 at commit [`714cb43`](https://github.com/apache/spark/commit/714cb43dc39d0bde5b920f66aee0f5772fc281d3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950171883
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49027/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950188762
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49029/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950213756
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49031/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950207356
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49031/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948632459
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144504/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948635526
**[Test build #144508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144508/testReport)** for PR 34296 at commit [`cf13fbb`](https://github.com/apache/spark/commit/cf13fbbaa56cc3a37777062d1f14017a8ed68b66).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950161755
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49027/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950198914
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144558/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950197317
**[Test build #144560 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144560/testReport)** for PR 34296 at commit [`e052edc`](https://github.com/apache/spark/commit/e052edcd10712e604bd20c25db236f6fdb673d28).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-944441189
cc @HyukjinKwon @itholic @ueshin @xinrong-databricks FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945879571
**[Test build #144371 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144371/testReport)** for PR 34296 at commit [`62018ce`](https://github.com/apache/spark/commit/62018ce594a02b19747595a25df4be9b8e571bfd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` class Foo(Params):`
* ` class Bar(Params):`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948579161
**[Test build #144507 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144507/testReport)** for PR 34296 at commit [`714cb43`](https://github.com/apache/spark/commit/714cb43dc39d0bde5b920f66aee0f5772fc281d3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-947625321
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144457/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-947503120
**[Test build #144457 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144457/testReport)** for PR 34296 at commit [`d3d3755`](https://github.com/apache/spark/commit/d3d375504b8ec502d917011ede43ac9f78e1bb44).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948057690
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48945/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948562372
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48976/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948793183
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144508/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950126066
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49024/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950126221
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49024/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950198719
**[Test build #144558 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144558/testReport)** for PR 34296 at commit [`1ae0494`](https://github.com/apache/spark/commit/1ae0494ae4a783a2534b9c7798b6f5b9c5dcc87f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950198914
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144558/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950148221
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49025/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950144690
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49025/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950196873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950156554
**[Test build #144556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144556/testReport)** for PR 34296 at commit [`d7bb84b`](https://github.com/apache/spark/commit/d7bb84b30d3f37658bd20887bf8f3aeb9dea4cb0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-944442460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-947503120
**[Test build #144457 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144457/testReport)** for PR 34296 at commit [`d3d3755`](https://github.com/apache/spark/commit/d3d375504b8ec502d917011ede43ac9f78e1bb44).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948485764
**[Test build #144504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144504/testReport)** for PR 34296 at commit [`cf13fbb`](https://github.com/apache/spark/commit/cf13fbbaa56cc3a37777062d1f14017a8ed68b66).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948485764
**[Test build #144504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144504/testReport)** for PR 34296 at commit [`cf13fbb`](https://github.com/apache/spark/commit/cf13fbbaa56cc3a37777062d1f14017a8ed68b66).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948611438
**[Test build #144504 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144504/testReport)** for PR 34296 at commit [`cf13fbb`](https://github.com/apache/spark/commit/cf13fbbaa56cc3a37777062d1f14017a8ed68b66).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950218986
**[Test build #144560 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144560/testReport)** for PR 34296 at commit [`e052edc`](https://github.com/apache/spark/commit/e052edcd10712e604bd20c25db236f6fdb673d28).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950222851
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144560/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34296:
URL: https://github.com/apache/spark/pull/34296#discussion_r733085834
##########
File path: dev/lint-python
##########
@@ -124,39 +125,76 @@ function pycodestyle_test {
fi
}
-function mypy_test {
- local MYPY_REPORT=
- local MYPY_STATUS=
- if ! hash "$MYPY_BUILD" 2> /dev/null; then
- echo "The $MYPY_BUILD command was not found. Skipping for now."
- return
+function mypy_annotation_test {
+ local PYTEST_REPORT=
+ local PYTEST_STATUS=
+
+ echo "starting mypy annotations test..."
+ PYTEST_REPORT=$( ($MYPY_BUILD \
+ --config-file python/mypy.ini \
+ --cache-dir /tmp/.mypy_cache/ \
Review comment:
If we set `--cache-dir` here explicitly, we can reuse cached for the data tests.
Alternatively, we can use `$PWD` as the `--mypy-testing-base` in the data tests, but I'd prefer to avoid that, because temporary files are written there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950034494
**[Test build #144548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144548/testReport)** for PR 34296 at commit [`cf8e27c`](https://github.com/apache/spark/commit/cf8e27c53efd6623ed7a1dfa6fa7068c5cc98678).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950187716
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49028/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950188823
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49028/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948793183
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144508/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950148221
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49025/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950182937
**[Test build #144558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144558/testReport)** for PR 34296 at commit [`1ae0494`](https://github.com/apache/spark/commit/1ae0494ae4a783a2534b9c7798b6f5b9c5dcc87f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945901934
**[Test build #144374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144374/testReport)** for PR 34296 at commit [`13ad5e3`](https://github.com/apache/spark/commit/13ad5e3287e5eff221570fa705d546c189aa1254).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948674345
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48980/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #34296:
URL: https://github.com/apache/spark/pull/34296#discussion_r734833122
##########
File path: dev/lint-python
##########
@@ -124,39 +125,76 @@ function pycodestyle_test {
fi
}
-function mypy_test {
- local MYPY_REPORT=
- local MYPY_STATUS=
- if ! hash "$MYPY_BUILD" 2> /dev/null; then
- echo "The $MYPY_BUILD command was not found. Skipping for now."
- return
+function mypy_annotation_test {
Review comment:
So this is the mypy test equivalent to the existing one, right?
##########
File path: dev/lint-python
##########
@@ -124,39 +125,76 @@ function pycodestyle_test {
fi
}
-function mypy_test {
- local MYPY_REPORT=
- local MYPY_STATUS=
- if ! hash "$MYPY_BUILD" 2> /dev/null; then
- echo "The $MYPY_BUILD command was not found. Skipping for now."
- return
+function mypy_annotation_test {
+ local PYTEST_REPORT=
+ local PYTEST_STATUS=
Review comment:
We can keep the names `MYPY_REPORT` and `MYPY_STATUS`?
##########
File path: dev/lint-python
##########
@@ -124,39 +125,76 @@ function pycodestyle_test {
fi
}
-function mypy_test {
- local MYPY_REPORT=
- local MYPY_STATUS=
- if ! hash "$MYPY_BUILD" 2> /dev/null; then
- echo "The $MYPY_BUILD command was not found. Skipping for now."
- return
+function mypy_annotation_test {
+ local PYTEST_REPORT=
+ local PYTEST_STATUS=
+
+ echo "starting mypy annotations test..."
+ PYTEST_REPORT=$( ($MYPY_BUILD \
+ --config-file python/mypy.ini \
+ --cache-dir /tmp/.mypy_cache/ \
+ python/pyspark) 2>&1)
+ PYTEST_STATUS=$?
+
+ if [ "$PYTEST_STATUS" -ne 0 ]; then
+ echo "annotations failed mypy checks:"
+ echo "$PYTEST_REPORT"
+ echo "$PYTEST_STATUS"
+ exit "$PYTEST_STATUS"
+ else
+ echo "annotations passed mypy checks."
+ echo
fi
+}
- _MYPY_VERSION=($($MYPY_BUILD --version))
- MYPY_VERSION="${_MYPY_VERSION[1]}"
- EXPECTED_MYPY="$(satisfies_min_version $MYPY_VERSION $MINIMUM_MYPY)"
- if [[ "$EXPECTED_MYPY" == "False" ]]; then
- echo "The minimum mypy version needs to be $MINIMUM_MYPY. Your current version is $MYPY_VERSION. Skipping for now."
- return
Review comment:
Seems like this check is missing? We should keep it in `mypy_test`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945135265
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144331/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-944442460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945135265
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144331/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945995308
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48848/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948690506
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48979/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-948578406
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48976/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945901934
**[Test build #144374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144374/testReport)** for PR 34296 at commit [`13ad5e3`](https://github.com/apache/spark/commit/13ad5e3287e5eff221570fa705d546c189aa1254).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-946050801
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144374/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-945979345
__Quick update__:
All test files from `pyspark-stubs` where migrated and dev scripts are prepared.
However, I hit typeddjango/pytest-mypy-plugins#83, which has serious impact on test performance, when numpy is installed (the whole suite requires > 20 minutes, compared to ~50 seconds when numpy is not present).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [WIP][SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-947575929
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48930/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950141060
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144553/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950139493
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49025/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950171883
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49027/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950182937
**[Test build #144558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144558/testReport)** for PR 34296 at commit [`1ae0494`](https://github.com/apache/spark/commit/1ae0494ae4a783a2534b9c7798b6f5b9c5dcc87f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950134359
**[Test build #144554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144554/testReport)** for PR 34296 at commit [`014e316`](https://github.com/apache/spark/commit/014e316c5206afe66e0ef0da0a044c0d1e0a03e7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-950172264
**[Test build #144557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144557/testReport)** for PR 34296 at commit [`b3e3f25`](https://github.com/apache/spark/commit/b3e3f257d6add7097bb37ff1744efadde774990c).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 closed pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
zero323 closed pull request #34296:
URL: https://github.com/apache/spark/pull/34296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34296:
URL: https://github.com/apache/spark/pull/34296#issuecomment-951710439
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ueshin commented on a change in pull request #34296: [SPARK-36989][TESTS][PYTHON] Add type hints data tests
Posted by GitBox <gi...@apache.org>.
ueshin commented on a change in pull request #34296:
URL: https://github.com/apache/spark/pull/34296#discussion_r734910279
##########
File path: dev/lint-python
##########
@@ -124,10 +125,66 @@ function pycodestyle_test {
fi
}
-function mypy_test {
+
+function mypy_annotation_test {
local MYPY_REPORT=
local MYPY_STATUS=
+ echo "starting mypy annotations test..."
+ MYPY_REPORT=$( ($MYPY_BUILD \
+ --config-file python/mypy.ini \
+ --cache-dir /tmp/.mypy_cache/ \
+ python/pyspark) 2>&1)
+ MYPY_STATUS=$?
+
+ if [ "$MYPY_STATUS" -ne 0 ]; then
+ echo "annotations failed mypy checks:"
+ echo "$MYPY_REPORT"
+ echo "$MYPY_STATUS"
+ exit "$MYPY_STATUS"
+ else
+ echo "annotations passed mypy checks."
+ echo
+ fi
+}
+
+
+function mypy_data_test {
+ local PYTEST_REPORT=
+ local PYTEST_STATUS=
+
+ echo "starting mypy data test..."
+
+ if [ "$(pip freeze | grep -c pytest-mypy-plugins )" -eq 0 ]; then
+ echo "pytest-mypy-plugins missing. Skipping for now."
+ return
+ fi
+
+ PYTEST_REPORT=$( (MYPYPATH=python $PYTEST_BUILD \
+ -c python/pyproject.toml \
+ --rootdir python \
+ --mypy-only-local-stub \
+ --mypy-ini-file python/mypy.ini \
+ python/pyspark ) 2>&1)
+
+ PYTEST_STATUS=$?
+
+ if [ "$PYTEST_STATUS" -ne 0 ]; then
+ echo "annotations failed data checks:"
+ echo "$PYTEST_REPORT"
+ echo "$PYTEST_STATUS"
+ exit "$PYTEST_STATUS"
+ else
+ echo "annotations passed data checks."
+ echo
+ fi
+}
+
+
+function mypy_test {
+ local PYTEST_REPORT=
+ local PYTEST_STATUS=
Review comment:
We don't need these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org