You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/15 06:54:07 UTC

[GitHub] [pulsar] jerrypeng commented on a change in pull request #6964: Change the signature of loadFromSecrets to make it more saner

jerrypeng commented on a change in pull request #6964:
URL: https://github.com/apache/pulsar/pull/6964#discussion_r425601697



##########
File path: pulsar-io/twitter/src/main/java/org/apache/pulsar/io/twitter/TwitterFireHose.java
##########
@@ -72,7 +72,8 @@
 
     @Override
     public void open(Map<String, Object> config, SourceContext sourceContext) throws IOException {
-        TwitterFireHoseConfig hoseConfig = IOConfigUtils.loadWithSecrets(config, TwitterFireHoseConfig.class, sourceContext);
+        TwitterFireHoseConfig hoseConfigWithoutSecrets = TwitterFireHoseConfig.load(config);

Review comment:
       I don't quite understand why we need to separate this into two calls?  Seems to make things more complicated than necessary?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org