[GitHub] [rocketmq] drpmma commented on a diff in pull request #6207: Use static subscription to calculate consumer lag and latency

["drpmma (via GitHub)" <gi...@apache.org>]

drpmma commented on code in PR #6207:
URL: https://github.com/apache/rocketmq/pull/6207#discussion_r1124399936


##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/subscription/SubscriptionGroupConfig.java:
##########
@@ -149,6 +153,14 @@ public void setConsumeTimeoutMinute(int consumeTimeoutMinute) {
         this.consumeTimeoutMinute = consumeTimeoutMinute;
     }
 
+    public Set<SimpleSubscriptionData> getSubscriptionDataSet() {

Review Comment:
   Because it's possible that there's more that one SimpleSubscriptionData for a topic.



##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/subscription/SubscriptionGroupConfig.java:
##########
@@ -149,6 +153,14 @@ public void setConsumeTimeoutMinute(int consumeTimeoutMinute) {
         this.consumeTimeoutMinute = consumeTimeoutMinute;
     }
 
+    public Set<SimpleSubscriptionData> getSubscriptionDataSet() {

Review Comment:
   Because it's possible that there's more than one SimpleSubscriptionData for a topic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org