You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Marty Sweet <ms...@gmail.com> on 2013/08/25 14:23:06 UTC
Review Request 13798: CLOUDSTACK-1525: [DOC] Added - Accessing System VMs
via SSH
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13798/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-1525
Repository: cloudstack-git
Description
-------
Added two files (accessing-system-vms.xml and images/view-systemvm-details.png) which covers details explained in CLOUDSTACK-1525 on how to use private keys to access System VMs.
Added menu item to working-with-system-vm.xml
Diffs
-----
docs/en-US/accessing-system-vms.xml PRE-CREATION
docs/en-US/images/view-systemvm-details.png PRE-CREATION
docs/en-US/working-with-system-vm.xml 70f7dd1
Diff: https://reviews.apache.org/r/13798/diff/
Testing
-------
Built successfully with Publican
Thanks,
Marty Sweet
Re: Review Request 13798: CLOUDSTACK-1525: [DOC] Added - Accessing System
VMs via SSH
Posted by Marty Sweet <ms...@gmail.com>.
> On Aug. 25, 2013, 3:42 p.m., David Nalley wrote:
> > Marty: On the new file can you put in a license header. See http://www.apache.org/legal/src-headers.html for details on the policy - and see any of the other XML files in publican for examples. Can you fix and resubmit?
> > Otherwise this looks good.
> > --David
Hi David,
As far as I can tell this notice is already on lines 7-23 of docs/en-US/accessing-system-vms.xml. Do you mean another file?
Thanks,
Marty
- Marty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13798/#review25518
-----------------------------------------------------------
On Aug. 25, 2013, 12:23 p.m., Marty Sweet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13798/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2013, 12:23 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-1525
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added two files (accessing-system-vms.xml and images/view-systemvm-details.png) which covers details explained in CLOUDSTACK-1525 on how to use private keys to access System VMs.
> Added menu item to working-with-system-vm.xml
>
>
> Diffs
> -----
>
> docs/en-US/accessing-system-vms.xml PRE-CREATION
> docs/en-US/images/view-systemvm-details.png PRE-CREATION
> docs/en-US/working-with-system-vm.xml 70f7dd1
>
> Diff: https://reviews.apache.org/r/13798/diff/
>
>
> Testing
> -------
>
> Built successfully with Publican
>
>
> Thanks,
>
> Marty Sweet
>
>
Re: Review Request 13798: CLOUDSTACK-1525: [DOC] Added - Accessing System
VMs via SSH
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13798/#review25518
-----------------------------------------------------------
Marty: On the new file can you put in a license header. See http://www.apache.org/legal/src-headers.html for details on the policy - and see any of the other XML files in publican for examples. Can you fix and resubmit?
Otherwise this looks good.
--David
- David Nalley
On Aug. 25, 2013, 12:23 p.m., Marty Sweet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13798/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2013, 12:23 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-1525
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added two files (accessing-system-vms.xml and images/view-systemvm-details.png) which covers details explained in CLOUDSTACK-1525 on how to use private keys to access System VMs.
> Added menu item to working-with-system-vm.xml
>
>
> Diffs
> -----
>
> docs/en-US/accessing-system-vms.xml PRE-CREATION
> docs/en-US/images/view-systemvm-details.png PRE-CREATION
> docs/en-US/working-with-system-vm.xml 70f7dd1
>
> Diff: https://reviews.apache.org/r/13798/diff/
>
>
> Testing
> -------
>
> Built successfully with Publican
>
>
> Thanks,
>
> Marty Sweet
>
>
Re: Review Request 13798: CLOUDSTACK-1525: [DOC] Added - Accessing System
VMs via SSH
Posted by David Nalley <da...@gnsa.us>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13798/#review25794
-----------------------------------------------------------
Ship it!
Thanks for the patch - applied to master and 4.2-forward
- David Nalley
On Aug. 25, 2013, 12:23 p.m., Marty Sweet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13798/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2013, 12:23 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-1525
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added two files (accessing-system-vms.xml and images/view-systemvm-details.png) which covers details explained in CLOUDSTACK-1525 on how to use private keys to access System VMs.
> Added menu item to working-with-system-vm.xml
>
>
> Diffs
> -----
>
> docs/en-US/accessing-system-vms.xml PRE-CREATION
> docs/en-US/images/view-systemvm-details.png PRE-CREATION
> docs/en-US/working-with-system-vm.xml 70f7dd1
>
> Diff: https://reviews.apache.org/r/13798/diff/
>
>
> Testing
> -------
>
> Built successfully with Publican
>
>
> Thanks,
>
> Marty Sweet
>
>