You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/10/08 22:32:40 UTC
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11619
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
[DOCS] Built-in Functions doc format Changes
- The function titles were changed to upper case.
- The function titles no longer use <codeph>. <codeph> font appears
smaller than the <p> font.
- Return type were changed to upper case data types.
- Minor typos were fixed, such as extra commas and periods in titles.
Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
---
M docs/topics/impala_aggregate_functions.xml
M docs/topics/impala_analytic_functions.xml
M docs/topics/impala_bit_functions.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_functions.xml
M docs/topics/impala_math_functions.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_string_functions.xml
10 files changed, 3,710 insertions(+), 2,224 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/11619/1
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 )
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11619/2/docs/topics/impala_conversion_functions.xml
File docs/topics/impala_conversion_functions.xml:
http://gerrit.cloudera.org:8080/#/c/11619/2/docs/topics/impala_conversion_functions.xml@221
PS2, Line 221: <!--AR 9/4/2019: The following functions were hidden by John Russell. Dan H's comment was that these are used internally to implement CAST(expr as type). He does not think it makes sense to expose them in the docs .-->
Why the decision to keep them around rather than just remove?
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 20:43:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11619 )
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
[DOCS] Built-in Functions doc format Changes
- The function titles were changed to upper case.
- The function titles no longer use <codeph>. <codeph> font appears
smaller than the <p> font.
- Return type were changed to upper case data types.
- Minor typos were fixed, such as extra commas and periods in titles.
- The indexterm dita elememts were removed. Indexterm was incomplete
and WIP. No plan to go ahead and implement it, so removed.
Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Reviewed-on: http://gerrit.cloudera.org:8080/11619
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Brown <mi...@cloudera.com>
---
M docs/shared/impala_common.xml
M docs/topics/impala_aggregate_functions.xml
M docs/topics/impala_analytic_functions.xml
M docs/topics/impala_bit_functions.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_functions.xml
M docs/topics/impala_math_functions.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_string_functions.xml
11 files changed, 3,379 insertions(+), 2,721 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Brown: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 )
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/93/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 22:29:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 )
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/91/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Oct 2018 22:32:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11619
to look at the new patch set (#2).
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
[DOCS] Built-in Functions doc format Changes
- The function titles were changed to upper case.
- The function titles no longer use <codeph>. <codeph> font appears
smaller than the <p> font.
- Return type were changed to upper case data types.
- Minor typos were fixed, such as extra commas and periods in titles.
- The indexterm dita elememts were removed. Indexterm was incomplete
and WIP. No plan to go ahead and implement it, so removed.
Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
---
M docs/topics/impala_aggregate_functions.xml
M docs/topics/impala_analytic_functions.xml
M docs/topics/impala_bit_functions.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_functions.xml
M docs/topics/impala_math_functions.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_string_functions.xml
10 files changed, 3,710 insertions(+), 2,224 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/11619/2
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 )
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/93/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 22:16:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 )
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
Patch Set 2:
In Patch Set 2:
- Hidden conversion functions were removed.
- A missing space in impala_misc_functions was added.
- Replaced double quotes with single quotes for consistency in impala_datetime_functions.
- Removed unhelpful and confusing examples that also took too long to run from impala_conversion_functions.
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 21:56:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 )
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
Patch Set 2:
> (1 comment)
Removed.
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 21:53:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Greg Rahn, Michael Brown, Jim Apple, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11619
to look at the new patch set (#3).
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
[DOCS] Built-in Functions doc format Changes
- The function titles were changed to upper case.
- The function titles no longer use <codeph>. <codeph> font appears
smaller than the <p> font.
- Return type were changed to upper case data types.
- Minor typos were fixed, such as extra commas and periods in titles.
- The indexterm dita elememts were removed. Indexterm was incomplete
and WIP. No plan to go ahead and implement it, so removed.
Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
---
M docs/shared/impala_common.xml
M docs/topics/impala_aggregate_functions.xml
M docs/topics/impala_analytic_functions.xml
M docs/topics/impala_bit_functions.xml
M docs/topics/impala_conditional_functions.xml
M docs/topics/impala_conversion_functions.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_functions.xml
M docs/topics/impala_math_functions.xml
M docs/topics/impala_misc_functions.xml
M docs/topics/impala_string_functions.xml
11 files changed, 3,379 insertions(+), 2,721 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/11619/3
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 )
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/91/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Oct 2018 22:39:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 )
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 18:15:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Built-in Functions doc format Changes
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/11619 )
Change subject: [DOCS] Built-in Functions doc format Changes
......................................................................
Patch Set 2:
I don't think you used "git add" or something else went wrong for PS 2. The reasons for my suspicions:
1. The upload of PS2 just says "Uploaded patch set 2: Commit message was updated." This is all that Gerrit detected changed.
2. The diff between PS1 and PS2 (diff of diffs) doesn't show any meaningful changes to file. https://gerrit.cloudera.org/#/c/11619/1..2
--
To view, visit http://gerrit.cloudera.org:8080/11619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I797532463da8d29fe5bc7543cfdfb5b2b82db197
Gerrit-Change-Number: 11619
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 22:02:27 +0000
Gerrit-HasComments: No