You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Tedy Marcos Colombini (JIRA)" <ji...@apache.org> on 2006/06/22 16:57:16 UTC
[jira] Created: (STR-2893) doesn't render the focus
javascript compliant with xhtml
<html:form> doesn't render the focus javascript compliant with xhtml
--------------------------------------------------------------------
Key: STR-2893
URL: http://issues.apache.org/struts/browse/STR-2893
Project: Struts Action 1
Type: Bug
Components: Taglibs
Versions: 1.2 Family
Environment: Windows XP SP2, IBM Think Centre
Reporter: Tedy Marcos Colombini
Priority: Trivial
Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
// xhtml script content shouldn't use the browser hiding trick
if (!this.isXhtml()) {
results.append(" <!--");
results.append(lineEnd);
}
I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
Also, the following snippet doesn't need the !this.isXhtml() check...
if (!this.isXhtml() && this.scriptLanguage) {
results.append(" language=\"JavaScript\"");
}
Regards, Tedy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated STR-2893:
-------------------------------
Fix Version/s: 1.3.11
Fair enough desire. I will backport this.
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Tag Libraries
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Priority: Trivial
> Fix For: 1.3.11, 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46853#action_46853 ]
Paul Benedict commented on STR-2893:
------------------------------------
I wish I could give a pre-built SNAPSHOT to you, but I am unable to log into Apache Continuum. You could download the struts project at http://svn.apache.org/viewvc/struts/struts1/branches/STRUTS_1_3_BRANCH/ and build it yourself with Maven.
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Tag Libraries
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Assignee: Paul Benedict
> Priority: Trivial
> Fix For: 1.3.11, 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46824#action_46824 ]
Paul Benedict commented on STR-2893:
------------------------------------
The build is found here but something isn't working since it hasn't rebuilt in over a month.
http://vmbuild1.apache.org/continuum/workingCopy.action?projectId=153&projectName=Struts&userDirectory=taglib/target
I sent for help :-)
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Tag Libraries
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Assignee: Paul Benedict
> Priority: Trivial
> Fix For: 1.3.11, 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46814#action_46814 ]
Wes Wannemacher commented on STR-2893:
--------------------------------------
Sorry, that build is for 1.4.0-SNAPSHOT, I don't think we actively build 1.3 nightly. I'll leave that to Paul to give you instructions
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Tag Libraries
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Assignee: Paul Benedict
> Priority: Trivial
> Fix For: 1.3.11, 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (STR-2893) doesn't render the focus
javascript compliant with xhtml
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict resolved STR-2893.
--------------------------------
Resolution: Fixed
> <html:form> doesn't render the focus javascript compliant with xhtml
> --------------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Priority: Trivial
> Fix For: 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2893) doesn't render the focus
javascript compliant with xhtml
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41292 ]
Paul Benedict commented on STR-2893:
------------------------------------
The isXhtml() check is necessary to avoid emitting the @language attribute because, although its present in XHTML-1.0-Transitional, that attribute is not defined in XHTML-1.0-Strict.
References:
http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd
http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd
> <html:form> doesn't render the focus javascript compliant with xhtml
> --------------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Priority: Trivial
> Fix For: 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict reopened STR-2893:
--------------------------------
Assignee: Paul Benedict
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Tag Libraries
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Assignee: Paul Benedict
> Priority: Trivial
> Fix For: 1.3.11, 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Andrew Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46851#action_46851 ]
Andrew Kelly commented on STR-2893:
-----------------------------------
Is there any progress on this issue?
Is there a recent v1.3.11 build that I can test?
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Tag Libraries
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Assignee: Paul Benedict
> Priority: Trivial
> Fix For: 1.3.11, 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict resolved STR-2893.
--------------------------------
Resolution: Fixed
Andrew, the backport is checked in. Build a snapshot of 1.3.11 and tell me how it works for you. If there's anything buggy, let me know.
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Tag Libraries
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Assignee: Paul Benedict
> Priority: Trivial
> Fix For: 1.3.11, 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Wes Wannemacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46813#action_46813 ]
Wes Wannemacher commented on STR-2893:
--------------------------------------
If you start from this page -
http://hudson.zones.apache.org/hudson/view/Struts/job/struts1/lastBuild/
You can click into each module and download the jars
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Tag Libraries
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Assignee: Paul Benedict
> Priority: Trivial
> Fix For: 1.3.11, 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Andrew Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46693#action_46693 ]
Andrew Kelly commented on STR-2893:
-----------------------------------
It'd be nice to have this fixed earlier than v1.4, perhaps in v1.3.11.
The code for the fix is already present in the JavascriptValidatorTag class in the getJavascriptBegin/End methods...
if (this.isXhtml() && "true".equalsIgnoreCase(this.cdata)) {
sb.append("//<![CDATA[\r\n");
}
if (this.isXhtml() && "true".equalsIgnoreCase(this.cdata)) {
sb.append("//]]>\r\n");
}
This is important for us, as other have pointed out, the form tag doesn't render XHTML compliant javascript any more.
Regards,
Andy.
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Tag Libraries
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Priority: Trivial
> Fix For: 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Andrew Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46812#action_46812 ]
Andrew Kelly commented on STR-2893:
-----------------------------------
Is there a place I can download the pre-built nightly builds of v1.3.11?
The Nightly Builds link on this page just leads to an empty 1.3.x folder
http://struts.apache.org/builds.html
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Tag Libraries
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Assignee: Paul Benedict
> Priority: Trivial
> Fix For: 1.3.11, 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2893) doesn't render the focus
javascript compliant with xhtml
Posted by "Isaac Shabtay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40594 ]
Isaac Shabtay commented on STR-2893:
------------------------------------
Isn't this a regression from 1.2.4?
See STR-2232 which seems very similar but was fixed for 1.2.4.
I also recall programming some web-sites using Struts 1.2.x with "focus" on HTML forms using XHTML mode and it used to work just fine.
> <html:form> doesn't render the focus javascript compliant with xhtml
> --------------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Priority: Trivial
> Fix For: 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Andrew Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47104#action_47104 ]
Andrew Kelly commented on STR-2893:
-----------------------------------
Any word on when 1.3.11 will be released?
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Tag Libraries
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Assignee: Paul Benedict
> Priority: Trivial
> Fix For: 1.3.11, 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-2893) FormTag doesn't render the focus
javascript compliant with xhtml
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Benedict updated STR-2893:
-------------------------------
Summary: FormTag doesn't render the focus javascript compliant with xhtml (was: <html:form> doesn't render the focus javascript compliant with xhtml)
> FormTag doesn't render the focus javascript compliant with xhtml
> ----------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Priority: Trivial
> Fix For: 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (STR-2893) doesn't render the focus
javascript compliant with xhtml
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell updated STR-2893:
-------------------------------
Fix Version/s: 1.4.0
This seems like something we can easily take care of for the 1.4 release.
> <html:form> doesn't render the focus javascript compliant with xhtml
> --------------------------------------------------------------------
>
> Key: STR-2893
> URL: https://issues.apache.org/struts/browse/STR-2893
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Priority: Trivial
> Fix For: 1.4.0
>
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (STR-2893) doesn't render the focus
javascript compliant with xhtml
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2893?page=comments#action_37590 ]
Niall Pemberton commented on STR-2893:
--------------------------------------
My understanding is that XHTML browsers can ignore comments entirely and so rather than "hiding" the script it can disappear completely - so AFAIK the if statement here is correct.
To achieve the same in XHTML we should use a CDATA section (as the JavascriptValidatorTag does):
http://www.w3.org/TR/xhtml1/#h-4.8
...so perhaps we should implement the same for XHTML
> <html:form> doesn't render the focus javascript compliant with xhtml
> --------------------------------------------------------------------
>
> Key: STR-2893
> URL: http://issues.apache.org/struts/browse/STR-2893
> Project: Struts Action 1
> Type: Bug
> Components: Taglibs
> Versions: 1.2 Family
> Environment: Windows XP SP2, IBM Think Centre
> Reporter: Tedy Marcos Colombini
> Priority: Trivial
>
> Taking a look at the FormTag code (precisely, the renderFocusJavascript() method), I found this:
> // xhtml script content shouldn't use the browser hiding trick
> if (!this.isXhtml()) {
> results.append(" <!--");
> results.append(lineEnd);
> }
> I guess the if statement should be the opposite, since we need javascript code inside <!-- ... --> for xhtml compliance, don't we?
> Also, the following snippet doesn't need the !this.isXhtml() check...
> if (!this.isXhtml() && this.scriptLanguage) {
> results.append(" language=\"JavaScript\"");
> }
> Regards, Tedy.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira