You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/26 03:26:38 UTC

[GitHub] [rocketmq-client-go] yuanmoon opened a new pull request #761: Use proverty sendMsgTimeout instead of hard code for configure request timeout

yuanmoon opened a new pull request #761:
URL: https://github.com/apache/rocketmq-client-go/pull/761


   ## What is the purpose of the change
   
   https://github.com/apache/rocketmq-client-go/issues/721
   
   ## Brief changelog
   
   Optimize codeļ¼Œremove hard code and use proverty sendMsgTimeout
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] yuanmoon commented on pull request #761: [ISSUE #721] feat: use sendMsgTimeout option for sendSync

Posted by GitBox <gi...@apache.org>.
yuanmoon commented on pull request #761:
URL: https://github.com/apache/rocketmq-client-go/pull/761#issuecomment-1001102034


   @wenfengwang 
   So grateful if you can help to review and give some suggestion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org