You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/07/26 23:33:56 UTC

[GitHub] Jerryzcn commented on a change in pull request #11834: Fix mxnet ctc_loss bug

Jerryzcn commented on a change in pull request #11834: Fix mxnet ctc_loss bug
URL: https://github.com/apache/incubator-mxnet/pull/11834#discussion_r205631958
 
 

 ##########
 File path: src/operator/contrib/ctc_include/detail/gpu_ctc.h
 ##########
 @@ -411,12 +411,7 @@ GpuCTC<ProbT>::compute_log_probs(const ProbT* const activations) {
         denoms_, out_dim_, num_elements);
 
     // compute denominators for softmax
-    denoms_handle = reduce_with_axis<red::sum, false>(
-        F<mxnet::op::mshadow_op::exp>(
-            log_probs_handle -
-            broadcast<0>(reduce_with_axis<red::maximum, false>(log_probs_handle, 1),
 
 Review comment:
   max is necessary here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services