You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Matt Benson <gu...@gmail.com> on 2012/08/20 19:52:19 UTC
deprecations
Hi gang,
There are lots of methods in Ant's source that have been deprecated
since e.g. v1.6. Does anyone object to removing deprecated methods
for Ant 1.9?
Matt
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: deprecations
Posted by Maarten Coene <ma...@yahoo.com>.
I agree with Peter.
I think it's important that older 3th party tasks keep working with 1.x releases of Ant.
Maarten
________________________________
From: Peter Reilly <pe...@gmail.com>
To: Ant Developers List <de...@ant.apache.org>; gudnabrsam@gmail.com
Sent: Wednesday, August 22, 2012 10:52 AM
Subject: Re: deprecations
Just had a quick look at Project.
There are a lot of deprecated methods. However
I do not think that most of them are deprecated correctly.
Users of the api should not have to know about implementation
details and changes to implementation - for example the
FileUtils.getFileUtils().
I downloaded the latest svn trunk version of ant-contrib and
compiled it with -Xlint:deprecation. It uses a fair number of ant
deprecated methods.
Most of the issues could be removed. But... it would mean a new
version of ant-contrib
that would not work with old versions of ant (a very common occurrence).
I would suspect that most 3rd party task collections would have similar issues.
A major problem with the ant api is that is it not well specified
and so it is too big - it included nearly all the ant implementation, but
it is probably too late to fix that now.
So, yes I guess I would be opposed.
However for deprecated methods that need to be removed because it would
be impossible to implement with newer and better implementations, I would
have no problem with (perhaps using an implementation that throws
an UnsupportedOperationException("dead api").
Peter
On Wed, Aug 22, 2012 at 12:19 AM, Matt Benson <gu...@gmail.com> wrote:
> Hi Peter,
> So does that mean you would be opposed to removing these deprecated items?
>
> Matt
>
> On Tue, Aug 21, 2012 at 6:07 PM, Peter Reilly
> <pe...@gmail.com> wrote:
>> The only problem is the there are a lot
>> of tasks out there in the wild that have not
>> been compiled in a very long time. (I know
>> I have uses a number), These
>> will most likely use the deprecated methods,
>> especially in regard to handling of properties
>> and references.
>>
>> Peter
>>
>> 2012/8/20 Martin Gainty <mg...@hotmail.com>:
>>>
>>> Hi Matt
>>>
>>> as long as there is a new method (or new class) to replace the deprecated method (or deprectaed class)
>>>
>>> Many Thanks for your diligence!
>>> Martin
>>> ______________________________________________
>>> Verzicht und Vertraulichkeitanmerkung/Note de déni et de confidentialité
>>>
>>> Diese Nachricht ist vertraulich. Sollten Sie nicht der vorgesehene Empfaenger sein, so bitten wir hoeflich um eine Mitteilung. Jede unbefugte Weiterleitung oder Fertigung einer Kopie ist unzulaessig. Diese Nachricht dient lediglich dem Austausch von Informationen und entfaltet keine rechtliche Bindungswirkung. Aufgrund der leichten Manipulierbarkeit von E-Mails koennen wir keine Haftung fuer den Inhalt uebernehmen.
>>> Ce message est confidentiel et peut être privilégié. Si vous n'êtes pas le destinataire prévu, nous te demandons avec bonté que pour satisfaire informez l'expéditeur. N'importe quelle diffusion non autorisée ou la copie de ceci est interdite. Ce message sert à l'information seulement et n'aura pas n'importe quel effet légalement obligatoire. Étant donné que les email peuvent facilement être sujets à la manipulation, nous ne pouvons accepter aucune responsabilité pour le contenu fourni.
>>>
>>>
>>>> Date: Mon, 20 Aug 2012 12:52:19 -0500
>>>> Subject: deprecations
>>>> From: gudnabrsam@gmail.com
>>>> To: dev@ant.apache.org
>>>>
>>>> Hi gang,
>>>> There are lots of methods in Ant's source that have been deprecated
>>>> since e.g. v1.6. Does anyone object to removing deprecated methods
>>>> for Ant 1.9?
>>>>
>>>> Matt
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>>>> For additional commands, e-mail: dev-help@ant.apache.org
>>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: deprecations
Posted by Peter Reilly <pe...@gmail.com>.
Just had a quick look at Project.
There are a lot of deprecated methods. However
I do not think that most of them are deprecated correctly.
Users of the api should not have to know about implementation
details and changes to implementation - for example the
FileUtils.getFileUtils().
I downloaded the latest svn trunk version of ant-contrib and
compiled it with -Xlint:deprecation. It uses a fair number of ant
deprecated methods.
Most of the issues could be removed. But... it would mean a new
version of ant-contrib
that would not work with old versions of ant (a very common occurrence).
I would suspect that most 3rd party task collections would have similar issues.
A major problem with the ant api is that is it not well specified
and so it is too big - it included nearly all the ant implementation, but
it is probably too late to fix that now.
So, yes I guess I would be opposed.
However for deprecated methods that need to be removed because it would
be impossible to implement with newer and better implementations, I would
have no problem with (perhaps using an implementation that throws
an UnsupportedOperationException("dead api").
Peter
On Wed, Aug 22, 2012 at 12:19 AM, Matt Benson <gu...@gmail.com> wrote:
> Hi Peter,
> So does that mean you would be opposed to removing these deprecated items?
>
> Matt
>
> On Tue, Aug 21, 2012 at 6:07 PM, Peter Reilly
> <pe...@gmail.com> wrote:
>> The only problem is the there are a lot
>> of tasks out there in the wild that have not
>> been compiled in a very long time. (I know
>> I have uses a number), These
>> will most likely use the deprecated methods,
>> especially in regard to handling of properties
>> and references.
>>
>> Peter
>>
>> 2012/8/20 Martin Gainty <mg...@hotmail.com>:
>>>
>>> Hi Matt
>>>
>>> as long as there is a new method (or new class) to replace the deprecated method (or deprectaed class)
>>>
>>> Many Thanks for your diligence!
>>> Martin
>>> ______________________________________________
>>> Verzicht und Vertraulichkeitanmerkung/Note de déni et de confidentialité
>>>
>>> Diese Nachricht ist vertraulich. Sollten Sie nicht der vorgesehene Empfaenger sein, so bitten wir hoeflich um eine Mitteilung. Jede unbefugte Weiterleitung oder Fertigung einer Kopie ist unzulaessig. Diese Nachricht dient lediglich dem Austausch von Informationen und entfaltet keine rechtliche Bindungswirkung. Aufgrund der leichten Manipulierbarkeit von E-Mails koennen wir keine Haftung fuer den Inhalt uebernehmen.
>>> Ce message est confidentiel et peut être privilégié. Si vous n'êtes pas le destinataire prévu, nous te demandons avec bonté que pour satisfaire informez l'expéditeur. N'importe quelle diffusion non autorisée ou la copie de ceci est interdite. Ce message sert à l'information seulement et n'aura pas n'importe quel effet légalement obligatoire. Étant donné que les email peuvent facilement être sujets à la manipulation, nous ne pouvons accepter aucune responsabilité pour le contenu fourni.
>>>
>>>
>>>> Date: Mon, 20 Aug 2012 12:52:19 -0500
>>>> Subject: deprecations
>>>> From: gudnabrsam@gmail.com
>>>> To: dev@ant.apache.org
>>>>
>>>> Hi gang,
>>>> There are lots of methods in Ant's source that have been deprecated
>>>> since e.g. v1.6. Does anyone object to removing deprecated methods
>>>> for Ant 1.9?
>>>>
>>>> Matt
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>>>> For additional commands, e-mail: dev-help@ant.apache.org
>>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: deprecations
Posted by Matt Benson <gu...@gmail.com>.
Hi Peter,
So does that mean you would be opposed to removing these deprecated items?
Matt
On Tue, Aug 21, 2012 at 6:07 PM, Peter Reilly
<pe...@gmail.com> wrote:
> The only problem is the there are a lot
> of tasks out there in the wild that have not
> been compiled in a very long time. (I know
> I have uses a number), These
> will most likely use the deprecated methods,
> especially in regard to handling of properties
> and references.
>
> Peter
>
> 2012/8/20 Martin Gainty <mg...@hotmail.com>:
>>
>> Hi Matt
>>
>> as long as there is a new method (or new class) to replace the deprecated method (or deprectaed class)
>>
>> Many Thanks for your diligence!
>> Martin
>> ______________________________________________
>> Verzicht und Vertraulichkeitanmerkung/Note de déni et de confidentialité
>>
>> Diese Nachricht ist vertraulich. Sollten Sie nicht der vorgesehene Empfaenger sein, so bitten wir hoeflich um eine Mitteilung. Jede unbefugte Weiterleitung oder Fertigung einer Kopie ist unzulaessig. Diese Nachricht dient lediglich dem Austausch von Informationen und entfaltet keine rechtliche Bindungswirkung. Aufgrund der leichten Manipulierbarkeit von E-Mails koennen wir keine Haftung fuer den Inhalt uebernehmen.
>> Ce message est confidentiel et peut être privilégié. Si vous n'êtes pas le destinataire prévu, nous te demandons avec bonté que pour satisfaire informez l'expéditeur. N'importe quelle diffusion non autorisée ou la copie de ceci est interdite. Ce message sert à l'information seulement et n'aura pas n'importe quel effet légalement obligatoire. Étant donné que les email peuvent facilement être sujets à la manipulation, nous ne pouvons accepter aucune responsabilité pour le contenu fourni.
>>
>>
>>> Date: Mon, 20 Aug 2012 12:52:19 -0500
>>> Subject: deprecations
>>> From: gudnabrsam@gmail.com
>>> To: dev@ant.apache.org
>>>
>>> Hi gang,
>>> There are lots of methods in Ant's source that have been deprecated
>>> since e.g. v1.6. Does anyone object to removing deprecated methods
>>> for Ant 1.9?
>>>
>>> Matt
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>>> For additional commands, e-mail: dev-help@ant.apache.org
>>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: deprecations
Posted by Peter Reilly <pe...@gmail.com>.
The only problem is the there are a lot
of tasks out there in the wild that have not
been compiled in a very long time. (I know
I have uses a number), These
will most likely use the deprecated methods,
especially in regard to handling of properties
and references.
Peter
2012/8/20 Martin Gainty <mg...@hotmail.com>:
>
> Hi Matt
>
> as long as there is a new method (or new class) to replace the deprecated method (or deprectaed class)
>
> Many Thanks for your diligence!
> Martin
> ______________________________________________
> Verzicht und Vertraulichkeitanmerkung/Note de déni et de confidentialité
>
> Diese Nachricht ist vertraulich. Sollten Sie nicht der vorgesehene Empfaenger sein, so bitten wir hoeflich um eine Mitteilung. Jede unbefugte Weiterleitung oder Fertigung einer Kopie ist unzulaessig. Diese Nachricht dient lediglich dem Austausch von Informationen und entfaltet keine rechtliche Bindungswirkung. Aufgrund der leichten Manipulierbarkeit von E-Mails koennen wir keine Haftung fuer den Inhalt uebernehmen.
> Ce message est confidentiel et peut être privilégié. Si vous n'êtes pas le destinataire prévu, nous te demandons avec bonté que pour satisfaire informez l'expéditeur. N'importe quelle diffusion non autorisée ou la copie de ceci est interdite. Ce message sert à l'information seulement et n'aura pas n'importe quel effet légalement obligatoire. Étant donné que les email peuvent facilement être sujets à la manipulation, nous ne pouvons accepter aucune responsabilité pour le contenu fourni.
>
>
>> Date: Mon, 20 Aug 2012 12:52:19 -0500
>> Subject: deprecations
>> From: gudnabrsam@gmail.com
>> To: dev@ant.apache.org
>>
>> Hi gang,
>> There are lots of methods in Ant's source that have been deprecated
>> since e.g. v1.6. Does anyone object to removing deprecated methods
>> for Ant 1.9?
>>
>> Matt
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
RE: deprecations
Posted by Martin Gainty <mg...@hotmail.com>.
Hi Matt
as long as there is a new method (or new class) to replace the deprecated method (or deprectaed class)
Many Thanks for your diligence!
Martin
______________________________________________
Verzicht und Vertraulichkeitanmerkung/Note de déni et de confidentialité
Diese Nachricht ist vertraulich. Sollten Sie nicht der vorgesehene Empfaenger sein, so bitten wir hoeflich um eine Mitteilung. Jede unbefugte Weiterleitung oder Fertigung einer Kopie ist unzulaessig. Diese Nachricht dient lediglich dem Austausch von Informationen und entfaltet keine rechtliche Bindungswirkung. Aufgrund der leichten Manipulierbarkeit von E-Mails koennen wir keine Haftung fuer den Inhalt uebernehmen.
Ce message est confidentiel et peut être privilégié. Si vous n'êtes pas le destinataire prévu, nous te demandons avec bonté que pour satisfaire informez l'expéditeur. N'importe quelle diffusion non autorisée ou la copie de ceci est interdite. Ce message sert à l'information seulement et n'aura pas n'importe quel effet légalement obligatoire. Étant donné que les email peuvent facilement être sujets à la manipulation, nous ne pouvons accepter aucune responsabilité pour le contenu fourni.
> Date: Mon, 20 Aug 2012 12:52:19 -0500
> Subject: deprecations
> From: gudnabrsam@gmail.com
> To: dev@ant.apache.org
>
> Hi gang,
> There are lots of methods in Ant's source that have been deprecated
> since e.g. v1.6. Does anyone object to removing deprecated methods
> for Ant 1.9?
>
> Matt
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
Re: deprecations
Posted by Jesse Glick <jg...@cloudbees.com>.
On 08/20/2012 01:52 PM, Matt Benson wrote:
> There are lots of methods in Ant's source that have been deprecated since e.g. v1.6. Does anyone object to removing deprecated methods for Ant 1.9?
I think OK so long as you are talking about members in the Java API - I guess we are still keeping compatibility for deprecated task names and attributes.
We could probably remove things deprecated in 1.7 as well, since anyone using 1.8.x would have already seen the deprecation warnings, but up to you.
Lots of things are marked deprecated but do not mention since when; that needs to be corrected if they are retained.
I note with amusement that there are several @deprecated private members. If something is private you do not need to deprecate it - just delete it right away!
Make a record in the incompatible changes section of WHATSNEW of course.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org