You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Robert Synnott <ro...@gobblewook.com> on 2008/06/26 19:15:45 UTC
Fwd: Minor patch for Erlang libs
Sorry, I sent this to the old list. The problem is still present in
the new Apache repository, though.
---------- Forwarded message ----------
From: Robert Synnott <ro...@gobblewook.com>
Date: Thu, Jun 26, 2008 at 6:08 PM
Subject: Minor patch for Erlang libs
To: thrift@publists.facebook.com
Hi,
There's a minor problem with the current SVN Erlang libs; if your
service has a function which takes a boolean parameter, the value
passed in will ALWAYS be true. I'm slightly surprised that this hasn't
been a problem for anyone before. A patch to fix this is attached.
Thanks
Rob.
Re: Fwd: Minor patch for Erlang libs
Posted by Todd Lipcon <to...@amiestreet.com>.
Yep, confirmed. Patch looks good to me.
-Todd
On Thu, 26 Jun 2008, Robert Synnott wrote:
> Sorry, I sent this to the old list. The problem is still present in
> the new Apache repository, though.
>
>
> ---------- Forwarded message ----------
> From: Robert Synnott <ro...@gobblewook.com>
> Date: Thu, Jun 26, 2008 at 6:08 PM
> Subject: Minor patch for Erlang libs
> To: thrift@publists.facebook.com
>
>
> Hi,
> There's a minor problem with the current SVN Erlang libs; if your
> service has a function which takes a boolean parameter, the value
> passed in will ALWAYS be true. I'm slightly surprised that this hasn't
> been a problem for anyone before. A patch to fix this is attached.
> Thanks
> Rob.
>
Re: Minor patch for Erlang libs
Posted by Robert Synnott <ro...@gobblewook.com>.
On Thu, Jun 26, 2008 at 6:26 PM, Bryan Duxbury <br...@rapleaf.com> wrote:
> I think the proper course of action is to create a issue in the Thrift Jira
> and attach the patch to that.
>
> -Bryan
>
Ah, sorry about that; I didn't know it existed. I more or less messed
the move to Apache...
Rob
Re: Minor patch for Erlang libs
Posted by Bryan Duxbury <br...@rapleaf.com>.
I think the proper course of action is to create a issue in the
Thrift Jira and attach the patch to that.
-Bryan
On Jun 26, 2008, at 10:15 AM, Robert Synnott wrote:
> Sorry, I sent this to the old list. The problem is still present in
> the new Apache repository, though.
>
>
> ---------- Forwarded message ----------
> From: Robert Synnott <ro...@gobblewook.com>
> Date: Thu, Jun 26, 2008 at 6:08 PM
> Subject: Minor patch for Erlang libs
> To: thrift@publists.facebook.com
>
>
> Hi,
> There's a minor problem with the current SVN Erlang libs; if your
> service has a function which takes a boolean parameter, the value
> passed in will ALWAYS be true. I'm slightly surprised that this hasn't
> been a problem for anyone before. A patch to fix this is attached.
> Thanks
> Rob.