You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/14 05:29:39 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #6528: [INLONG-6526][Manager] Fix the problem of mananger-client calling to forcibly delete the source interface failed
fuweng11 opened a new pull request, #6528:
URL: https://github.com/apache/inlong/pull/6528
### Prepare a Pull Request
- Fixes #6526
### Motivation
Fix the problem of mananger-client calling to forcibly delete the source interface failed
### Modifications
Modified the parameter name of the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #6528: [INLONG-6526][Manager] Fix the manager-client force delete the stream source failed
Posted by GitBox <gi...@apache.org>.
healchow merged PR #6528:
URL: https://github.com/apache/inlong/pull/6528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6528: [INLONG-6526][Manager] Fix the manager-client force delete the stream source failed
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6528:
URL: https://github.com/apache/inlong/pull/6528#discussion_r1021115088
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/StreamSourceController.java:
##########
@@ -91,11 +91,12 @@ public Response<Boolean> delete(@PathVariable Integer id) {
@OperationLog(operation = OperationType.DELETE)
@ApiOperation(value = "Force delete stream source by groupId and streamId")
@ApiImplicitParams({
- @ApiImplicitParam(name = "groupId", dataTypeClass = String.class, required = true),
- @ApiImplicitParam(name = "streamId", dataTypeClass = String.class, required = true)
+ @ApiImplicitParam(name = "inlongGroupId", dataTypeClass = String.class, required = true),
+ @ApiImplicitParam(name = "inlongStreamId", dataTypeClass = String.class, required = true)
})
- public Response<Boolean> forceDelete(@RequestParam String groupId, @RequestParam String streamId) {
- return Response.success(sourceService.forceDelete(groupId, streamId, LoginUserUtils.getLoginUser().getName()));
+ public Response<Boolean> forceDelete(@RequestParam String inlongGroupId, @RequestParam String inlongStreamId) {
Review Comment:
Fine, It can be added to any module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6528: [INLONG-6526][Manager] Fix the problem of mananger-client calling to forcibly delete the source interface failed
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6528:
URL: https://github.com/apache/inlong/pull/6528#discussion_r1021106678
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/StreamSourceController.java:
##########
@@ -91,11 +91,12 @@ public Response<Boolean> delete(@PathVariable Integer id) {
@OperationLog(operation = OperationType.DELETE)
@ApiOperation(value = "Force delete stream source by groupId and streamId")
@ApiImplicitParams({
- @ApiImplicitParam(name = "groupId", dataTypeClass = String.class, required = true),
- @ApiImplicitParam(name = "streamId", dataTypeClass = String.class, required = true)
+ @ApiImplicitParam(name = "inlongGroupId", dataTypeClass = String.class, required = true),
+ @ApiImplicitParam(name = "inlongStreamId", dataTypeClass = String.class, required = true)
})
- public Response<Boolean> forceDelete(@RequestParam String groupId, @RequestParam String streamId) {
- return Response.success(sourceService.forceDelete(groupId, streamId, LoginUserUtils.getLoginUser().getName()));
+ public Response<Boolean> forceDelete(@RequestParam String inlongGroupId, @RequestParam String inlongStreamId) {
Review Comment:
Suggest changing in the client module.
##########
inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/StreamSourceController.java:
##########
@@ -91,11 +91,12 @@ public Response<Boolean> delete(@PathVariable Integer id) {
@OperationLog(operation = OperationType.DELETE)
@ApiOperation(value = "Force delete stream source by groupId and streamId")
@ApiImplicitParams({
- @ApiImplicitParam(name = "groupId", dataTypeClass = String.class, required = true),
- @ApiImplicitParam(name = "streamId", dataTypeClass = String.class, required = true)
+ @ApiImplicitParam(name = "inlongGroupId", dataTypeClass = String.class, required = true),
+ @ApiImplicitParam(name = "inlongStreamId", dataTypeClass = String.class, required = true)
})
- public Response<Boolean> forceDelete(@RequestParam String groupId, @RequestParam String streamId) {
- return Response.success(sourceService.forceDelete(groupId, streamId, LoginUserUtils.getLoginUser().getName()));
+ public Response<Boolean> forceDelete(@RequestParam String inlongGroupId, @RequestParam String inlongStreamId) {
Review Comment:
Suggest changing the client module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org