You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mf...@apache.org on 2014/11/06 22:11:35 UTC
svn commit: r1637224 - in
/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd:
AbstractPmdViolationCheckMojo.java PmdReport.java
Author: mfriedenhagen
Date: Thu Nov 6 21:11:35 2014
New Revision: 1637224
URL: http://svn.apache.org/r1637224
Log:
Fix checkstyle errors showing up due to new maven-checkstyle-plugin version in
current maven-plugins pom.
Modified:
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java
maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java
Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java?rev=1637224&r1=1637223&r2=1637224&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java Thu Nov 6 21:11:35 2014
@@ -22,7 +22,6 @@ package org.apache.maven.plugin.pmd;
import org.apache.maven.plugin.AbstractMojo;
import org.apache.maven.plugin.MojoExecutionException;
import org.apache.maven.plugin.MojoFailureException;
-import org.apache.maven.plugins.annotations.Component;
import org.apache.maven.plugins.annotations.Parameter;
import org.apache.maven.project.MavenProject;
import org.codehaus.plexus.util.StringUtils;
@@ -35,6 +34,7 @@ import java.util.List;
/**
* Base class for mojos that check if there were any PMD violations.
+ * @param <D> type of the check, e.g. {@link Violation} or {@link Duplication}.
*
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
* @version $Id$
@@ -245,7 +245,8 @@ public abstract class AbstractPmdViolati
{
if ( failureCount > 0 )
{
- message.append( "You have " ).append( failureCount ).append( " " ).append( key ).append( failureCount > 1 ? "s" : "" );
+ message.append( "You have " ).append( failureCount ).append( " " ).append( key )
+ .append( failureCount > 1 ? "s" : "" );
}
if ( warningCount > 0 )
Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java?rev=1637224&r1=1637223&r2=1637224&view=diff
==============================================================================
--- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java (original)
+++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java Thu Nov 6 21:11:35 2014
@@ -147,7 +147,8 @@ public class PmdReport
*
* @since 3.1
*/
- @Parameter( property = "pmd.benchmarkOutputFilename", defaultValue = "${project.build.directory}/pmd-benchmark.txt" )
+ @Parameter( property = "pmd.benchmarkOutputFilename",
+ defaultValue = "${project.build.directory}/pmd-benchmark.txt" )
private String benchmarkOutputFilename;
/**
@@ -331,7 +332,8 @@ public class PmdReport
if ( filesToProcess.isEmpty() && !"java".equals( language ) )
{
getLog().warn(
- "No files found to process. Did you add your additional source folders like javascript? (see also build-helper-maven-plugin)" );
+ "No files found to process. Did you add your additional source folders like javascript?"
+ + " (see also build-helper-maven-plugin)" );
}
}
catch ( IOException e )
@@ -359,7 +361,7 @@ public class PmdReport
getLog().debug( "Executing PMD..." );
PMD.processFiles( pmdConfiguration, ruleSetFactory, dataSources, ruleContext,
- Collections.<Renderer> emptyList() );
+ Collections.<Renderer>emptyList() );
if ( getLog().isDebugEnabled() )
{