You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/16 08:00:10 UTC
[GitHub] [tvm] SebastianBoblestETAS opened a new pull request #10267: refactored GraphProto.from_onnx into smaller functions
SebastianBoblestETAS opened a new pull request #10267:
URL: https://github.com/apache/tvm/pull/10267
I split GraphProto.from_onnx into smaller functions.
I find it useful to see faster what is going on.
Are such refactorings wanted in the TVM codebase?
I am aware that they require careful review without adding any functionality so a comment on that in general would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo merged pull request #10267: refactored GraphProto.from_onnx into smaller functions
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo merged pull request #10267:
URL: https://github.com/apache/tvm/pull/10267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #10267: refactored GraphProto.from_onnx into smaller functions
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #10267:
URL: https://github.com/apache/tvm/pull/10267#issuecomment-1048252323
It's probably a spurious failures @SebastianBoblestETAS . Just push an empty commit to your branch to retoggle CI. I'll take a look at this later in the week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #10267: refactored GraphProto.from_onnx into smaller functions
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10267:
URL: https://github.com/apache/tvm/pull/10267#issuecomment-1042277299
cc @mbrookhart @AndrewZhaoLuo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] SebastianBoblestETAS commented on pull request #10267: refactored GraphProto.from_onnx into smaller functions
Posted by GitBox <gi...@apache.org>.
SebastianBoblestETAS commented on pull request #10267:
URL: https://github.com/apache/tvm/pull/10267#issuecomment-1047986840
I cannot really say why the tests fail now. I am pretty confident they passed and I did not change anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org