You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/30 11:42:40 UTC

[GitHub] [incubator-nuttx] fjpanag opened a new pull request, #6961: Fixed format specifier in various prints.

fjpanag opened a new pull request, #6961:
URL: https://github.com/apache/incubator-nuttx/pull/6961

   ## Summary
   
   Various prints produced compiler warnings, because of wrong specifiers used, or wrong types.  
   This PR fixes these warnings.
   
   ## Impact
   
   Code builds without warnings.
   
   ## Testing
   
   Build test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6961: Fixed format specifier in various prints.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6961:
URL: https://github.com/apache/incubator-nuttx/pull/6961


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6961: Fixed format specifier in various prints.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6961:
URL: https://github.com/apache/incubator-nuttx/pull/6961#discussion_r958373615


##########
mm/kasan/kasan.c:
##########
@@ -101,7 +101,8 @@ static void kasan_report(FAR const void *addr, size_t size, bool is_write)
   if (++recursion == 1)
     {
       _alert("kasan detected a %s access error, address at %0#"PRIxPTR

Review Comment:
   can we change to %p instead casting?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #6961: Fixed format specifier in various prints.

Posted by GitBox <gi...@apache.org>.
fjpanag commented on code in PR #6961:
URL: https://github.com/apache/incubator-nuttx/pull/6961#discussion_r958375925


##########
mm/kasan/kasan.c:
##########
@@ -101,7 +101,8 @@ static void kasan_report(FAR const void *addr, size_t size, bool is_write)
   if (++recursion == 1)
     {
       _alert("kasan detected a %s access error, address at %0#"PRIxPTR

Review Comment:
   The thing with `%p` is that its formatting is implementation specific, so I guess the original author chose `PRIxPTR` to enforce a specific formatting.
   
   I am fine with whichever. Whatever you chose.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org