You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/12 15:38:00 UTC
[jira] [Commented] (NIFI-4177) MergeContent - Tar - Save
modification timestamp like Tar does
[ https://issues.apache.org/jira/browse/NIFI-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084170#comment-16084170 ]
ASF GitHub Bot commented on NIFI-4177:
--------------------------------------
GitHub user makosteel opened a pull request:
https://github.com/apache/nifi/pull/2002
NIFI-4177 MergeContent - Tar - Save modification timestamp like Tar does
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/makosteel/nifi NIFI-4177
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2002.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2002
----
commit 958843cb19a279734aee7cceae3615962f4f5cf0
Author: Wayne Steel <wa...@gmail.com>
Date: 2017-07-12T13:52:52Z
NIFI-4177 MergeContent - Tar - Save modification timestamp like Tar does
----
> MergeContent - Tar - Save modification timestamp like Tar does
> --------------------------------------------------------------
>
> Key: NIFI-4177
> URL: https://issues.apache.org/jira/browse/NIFI-4177
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.3.0
> Reporter: Wayne Steel
> Priority: Trivial
>
> Tar by default saves the modification timestamp of entries.
> This mainly affects file based entries so could be done on reading the attribute file.lastModifiedTime, if it exists, which is written to the flowfile by GetFile or ListFile processors.
> Otherwise just leave it out as it does now.
> I propose a property with the default expression ${file.lastModifiedTime} but the value must resolve to a date format of "yyyy-MM-dd'T'HH:mm:ssZ". It should only be enabled when MERGE_FORMAT is set to MERGE_FORMAT_TAR
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)