You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2017/07/13 23:28:33 UTC
Review Request 60856: GEODE-3052 Need to reset isCoordinator flag in
GMSLocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/
-----------------------------------------------------------
Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer.
Repository: geode
Description
-------
isCoordinator flag ensures that this process is becoming the
coordinator thus other process should join this process. But
when network parttion happens, we were not resetting this flag.
Now we reset isCoordinator flag when viewCreator thread shutdowns.
added unit test for it.
Diffs
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 2c56f5b
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 9591673
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java d8c12e2
Diff: https://reviews.apache.org/r/60856/diff/1/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag
in GMSLocator.
Posted by Brian Rowe <br...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/#review180500
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Rowe
On July 13, 2017, 11:28 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60856/
> -----------------------------------------------------------
>
> (Updated July 13, 2017, 11:28 p.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> isCoordinator flag ensures that this process is becoming the
> coordinator thus other process should join this process. But
> when network parttion happens, we were not resetting this flag.
>
> Now we reset isCoordinator flag when viewCreator thread shutdowns.
>
> added unit test for it.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 2c56f5b
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 9591673
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java d8c12e2
>
>
> Diff: https://reviews.apache.org/r/60856/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag
in GMSLocator.
Posted by Hitesh Khamesra <hk...@pivotal.io>.
> On July 14, 2017, 12:18 a.m., Bruce Schuchardt wrote:
> > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
> > Lines 288 (patched)
> > <https://reviews.apache.org/r/60856/diff/1/?file=1776283#file1776283line288>
> >
> > remove debug logging or set to debug/trace level. If you keep it you should use info("GMSLocator has coordinator flag {}", isCoordinator)
changed log message to debug.
- Hitesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/#review180497
-----------------------------------------------------------
On July 14, 2017, 5:06 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60856/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 5:06 p.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> isCoordinator flag ensures that this process is becoming the
> coordinator thus other process should join this process. But
> when network parttion happens, we were not resetting this flag.
>
> Now we reset isCoordinator flag when viewCreator thread shutdowns.
>
> added unit test for it.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 2c56f5b
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 9591673
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java d8c12e2
>
>
> Diff: https://reviews.apache.org/r/60856/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag
in GMSLocator.
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/#review180497
-----------------------------------------------------------
Fix the logging statement & you're good to go
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java
Lines 288 (patched)
<https://reviews.apache.org/r/60856/#comment255706>
remove debug logging or set to debug/trace level. If you keep it you should use info("GMSLocator has coordinator flag {}", isCoordinator)
- Bruce Schuchardt
On July 13, 2017, 4:28 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60856/
> -----------------------------------------------------------
>
> (Updated July 13, 2017, 4:28 p.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> isCoordinator flag ensures that this process is becoming the
> coordinator thus other process should join this process. But
> when network parttion happens, we were not resetting this flag.
>
> Now we reset isCoordinator flag when viewCreator thread shutdowns.
>
> added unit test for it.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 2c56f5b
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 9591673
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java d8c12e2
>
>
> Diff: https://reviews.apache.org/r/60856/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag
in GMSLocator.
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/#review180549
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On July 14, 2017, 10:06 a.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60856/
> -----------------------------------------------------------
>
> (Updated July 14, 2017, 10:06 a.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> isCoordinator flag ensures that this process is becoming the
> coordinator thus other process should join this process. But
> when network parttion happens, we were not resetting this flag.
>
> Now we reset isCoordinator flag when viewCreator thread shutdowns.
>
> added unit test for it.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 2c56f5b
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 9591673
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java d8c12e2
>
>
> Diff: https://reviews.apache.org/r/60856/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag
in GMSLocator.
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/
-----------------------------------------------------------
(Updated July 14, 2017, 5:06 p.m.)
Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer.
Changes
-------
Changed log message to debug
Repository: geode
Description
-------
isCoordinator flag ensures that this process is becoming the
coordinator thus other process should join this process. But
when network parttion happens, we were not resetting this flag.
Now we reset isCoordinator flag when viewCreator thread shutdowns.
added unit test for it.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 2c56f5b
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 9591673
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java d8c12e2
Diff: https://reviews.apache.org/r/60856/diff/2/
Changes: https://reviews.apache.org/r/60856/diff/1-2/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 60856: GEODE-3052 Need to reset isCoordinator flag
in GMSLocator.
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60856/#review180545
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On July 13, 2017, 11:28 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60856/
> -----------------------------------------------------------
>
> (Updated July 13, 2017, 11:28 p.m.)
>
>
> Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> isCoordinator flag ensures that this process is becoming the
> coordinator thus other process should join this process. But
> when network parttion happens, we were not resetting this flag.
>
> Now we reset isCoordinator flag when viewCreator thread shutdowns.
>
> added unit test for it.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocator.java 2c56f5b
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java 9591673
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java d8c12e2
>
>
> Diff: https://reviews.apache.org/r/60856/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>