You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/16 17:13:01 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #895: The first
JVM-only extension
ppalaga opened a new pull request #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #895:
The first JVM-only extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895#discussion_r393280096
##########
File path: tooling/create-extension-templates/runtime-pom.xml
##########
@@ -30,9 +30,10 @@
<artifactId>[=artifactId]</artifactId>
<name>[=namePrefix][=nameBase][=nameSegmentDelimiter]Runtime</name>
+ <description>[=description]</description>
<properties>
- <firstVersion>1.0.0-M6</firstVersion>
+ <firstVersion>1.0.0-M5</firstVersion>
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #895: The first JVM-only extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895#discussion_r393191536
##########
File path: tooling/create-extension-templates/runtime-pom.xml
##########
@@ -30,9 +30,10 @@
<artifactId>[=artifactId]</artifactId>
<name>[=namePrefix][=nameBase][=nameSegmentDelimiter]Runtime</name>
+ <description>[=description]</description>
<properties>
- <firstVersion>1.0.0-M6</firstVersion>
+ <firstVersion>1.0.0-M5</firstVersion>
Review comment:
Shouldn't it be M6?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #895: The first JVM-only extension
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895#discussion_r393191801
##########
File path: tooling/create-extension-templates/quarkus-extension.yaml
##########
@@ -0,0 +1,35 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "[=nameBase]"
+description: "[=description]"
+metadata:
+[#if !nativeSupported ] unlisted: true
+[/#if]
+[#if keywords?size > 0 ] keywords:
+[#list keywords as keyword]
+ - "[=keyword]"
+[/#list]
+[/#if]
+ guide: "[=guideUrl]"
+[#if categories?size > 0 ] categories:
+[#list categories as category]
+ - "[=category]"
+[/#list]
+[/#if]
+ status: "[=nativeSupported?then('stable', 'preview')]"
Review comment:
Auto generated `quarkus-extension.yaml` :heart_eyes:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga merged pull request #895: The first
JVM-only extension
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #895: The first JVM-only
extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895#issuecomment-599736522
There are two things missing:
* Running the JVM-only tests by the CI
* Listing the JVM-only extensions in the docs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #895: The first JVM-only
extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895#issuecomment-599739198
> There are two things missing:
>
> * Running the JVM-only tests by the CI
It should already be covered by the `build` jobs's `mvn clean install`.
> * Listing the JVM-only extensions in the docs
Can be done as a followup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #895: The first JVM-only
extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895#issuecomment-599658498
Any feedback is appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #895: The first JVM-only
extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895#issuecomment-599783126
Another followup: some source checks may need a reconfig
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga edited a comment on issue #895: The first
JVM-only extension
Posted by GitBox <gi...@apache.org>.
ppalaga edited a comment on issue #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895#issuecomment-599774323
ec0ec5f:
* Fixed the M5/6 issue found by @jamesnetherton
* Replaced the plugin refs in the docs
* Used the proper release of the plugin to generate the extension
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #895: The first JVM-only
extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895#issuecomment-599937187
@jamesnetherton reviewed and agreed to merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #895: The first JVM-only
extension
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #895: The first JVM-only extension
URL: https://github.com/apache/camel-quarkus/pull/895#issuecomment-599774323
ec0ec5f:
* Fixed the M5/6 issue found by @jamesnetherton
* Replaced the plugin in the docs
* Used the proper release of the plugin to generate the extension
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services