You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/08/25 13:51:08 UTC

[GitHub] [incubator-yunikorn-scheduler-interface] chia7712 opened a new pull request #52: [YUNIKORN-827] add to scheduler-interface-spec.md

chia7712 opened a new pull request #52:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/52


   ### What is this PR for?
   YUNIKORN-762 (https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/41) added the field to a "generated" file (`constants.go`) instead of `scheduler-interface-spec.md`. Hence, the field was removed after another PR (https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/42) got merged. 
   
   ### What type of PR is it?
   * [x] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-827
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] chia7712 commented on pull request #52: [YUNIKORN-827] add to scheduler-interface-spec.md

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #52:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/52#issuecomment-905597592


   @HuangTing-Yao thanks for your response. I noticed this issue when building k8shim with latest SI (the gRPC issue just get fixed). However, the missing field is another issue of building code.
   
   It is ok to close this PR since it seems this issue is  temporary and it can get fixed quickly :)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] HuangTing-Yao commented on pull request #52: [YUNIKORN-827] add to scheduler-interface-spec.md

Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on pull request #52:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/52#issuecomment-905559873


   Hi @chia7712 , Since we decided to implement [Yunikorn-704](https://issues.apache.org/jira/browse/YUNIKORN-704) in another way, I don't think we need const `ignoreUnschedulableNodes` anymore. What's your opinion? @yangwwei 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] chia7712 commented on pull request #52: [YUNIKORN-827] add to scheduler-interface-spec.md

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #52:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/52#issuecomment-905519920


   @HuangTing-Yao Could you please take a look? thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] chia7712 closed pull request #52: [YUNIKORN-827] add to scheduler-interface-spec.md

Posted by GitBox <gi...@apache.org>.
chia7712 closed pull request #52:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/52


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org