[GitHub] [pulsar] BewareMyPower opened a new pull request #6938: Fix message id error if messages were sent to a partitioned topic

[GitBox <gi...@apache.org>]

BewareMyPower opened a new pull request #6938:
URL: https://github.com/apache/pulsar/pull/6938


   ### Motivation
   
   If messages were sent to a partitioned topic, the message id's `partition` field was always -1 because SendReceipt command only contains ledger id and entry id.
   
   ### Modifications
   
   - Add a `partition` field to `ProducerImpl` and set the `MessageId`'s `partition` field with it in `ackReceived` method later.
   - Add a test to check message id in send callback if messages were sent to a partitioned topic.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests, such as `BasicEndToEndTest.testSendCallback`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #6938: [C++] Fix message id error if messages were sent to a partitioned topic

[GitBox <gi...@apache.org>]

BewareMyPower commented on pull request #6938:
URL: https://github.com/apache/pulsar/pull/6938#issuecomment-626653234


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org