You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/25 11:10:30 UTC

[GitHub] [cloudstack] weizhouapache opened a new pull request #5339: server: check server capacity when start/deploy a vm

weizhouapache opened a new pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339


   ### Description
   
   This PR fixes the issue that server capacity check is skipped, when start or migrate a vm with specified hostid.
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [x] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez removed a comment on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908822120


   @blueorangutan test ubuntu18 kvm-centos7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908780734


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-912138583


   <b>Trillian test result (tid-1943)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34076 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5339-t1943-kvm-centos7.zip
   Smoke tests completed. 87 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-907128781


     
   
   > @weizhouapache does this affect 4.15 too? If so, pl raise PR against 4.15 branch.
   
   @rhtyd @nvazquez changed base branch to 4.15


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez removed a comment on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908813581


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-904427789


   @nvazquez @davidjumani updated this pr.
   
   allow.deploy.vm.if.deploy.on.given.host.fails=false
   ![Screenshot from 2021-08-24 10-04-26](https://user-images.githubusercontent.com/57355700/130582382-877e85ea-8705-4cb4-8dd5-fb4a5da8a9f6.png)
   
   
   allow.deploy.vm.if.deploy.on.given.host.fails=true
   ![Screenshot from 2021-08-24 10-05-16](https://user-images.githubusercontent.com/57355700/130582402-e6b1b610-8a5b-4bf5-8b7f-76c21f0af015.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-901746671


   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908822448






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908796527


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1065


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908813984


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache closed pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#discussion_r694579868



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4935,9 +4935,17 @@ public void finalizeStop(VirtualMachineProfile profile, Answer answer) {
         boolean deployOnGivenHost = false;
         if (destinationHost != null) {
             s_logger.debug("Destination Host to deploy the VM is specified, specifying a deployment plan to deploy the VM");
-            plan = new DataCenterDeployment(vm.getDataCenterId(), destinationHost.getPodId(), destinationHost.getClusterId(), destinationHost.getId(), null, null);
-            if (!AllowDeployVmIfGivenHostFails.value()) {
-                deployOnGivenHost = true;
+            try {
+                checkVmDestinationServerCapacity(vm, destinationHost);

Review comment:
       @davidjumani  I will change it.thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908830721


   @blueorangutan test ubuntu18 kvm-ubuntu18


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-911204546


   Lgtm, failures not related to this PR.
   @weizhouapache @nvazquez @borisstoyanov @vladimirpetrov anybody testing this? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-909400665


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908780455






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-901746869


   @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#discussion_r693913840



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4935,9 +4935,17 @@ public void finalizeStop(VirtualMachineProfile profile, Answer answer) {
         boolean deployOnGivenHost = false;
         if (destinationHost != null) {
             s_logger.debug("Destination Host to deploy the VM is specified, specifying a deployment plan to deploy the VM");
-            plan = new DataCenterDeployment(vm.getDataCenterId(), destinationHost.getPodId(), destinationHost.getClusterId(), destinationHost.getId(), null, null);
-            if (!AllowDeployVmIfGivenHostFails.value()) {
-                deployOnGivenHost = true;
+            try {
+                checkVmDestinationServerCapacity(vm, destinationHost);
+                plan = new DataCenterDeployment(vm.getDataCenterId(), destinationHost.getPodId(), destinationHost.getClusterId(), destinationHost.getId(), null, null);
+                if (!AllowDeployVmIfGivenHostFails.value()) {
+                    deployOnGivenHost = true;
+                }
+            } catch (InvalidParameterValueException ex) {
+                s_logger.error("Cannot deploy the VM to specified host due to :" + ex.getMessage());

Review comment:
       ```suggestion
                   s_logger.error("Cannot deploy the VM to specified host due to: " + ex.getMessage());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#discussion_r694190833



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4935,9 +4935,17 @@ public void finalizeStop(VirtualMachineProfile profile, Answer answer) {
         boolean deployOnGivenHost = false;
         if (destinationHost != null) {
             s_logger.debug("Destination Host to deploy the VM is specified, specifying a deployment plan to deploy the VM");
-            plan = new DataCenterDeployment(vm.getDataCenterId(), destinationHost.getPodId(), destinationHost.getClusterId(), destinationHost.getId(), null, null);
-            if (!AllowDeployVmIfGivenHostFails.value()) {
-                deployOnGivenHost = true;
+            try {
+                checkVmDestinationServerCapacity(vm, destinationHost);
+                plan = new DataCenterDeployment(vm.getDataCenterId(), destinationHost.getPodId(), destinationHost.getClusterId(), destinationHost.getId(), null, null);
+                if (!AllowDeployVmIfGivenHostFails.value()) {
+                    deployOnGivenHost = true;
+                }
+            } catch (InvalidParameterValueException ex) {
+                s_logger.error("Cannot deploy the VM to specified host due to: " + ex.getMessage());

Review comment:
       We could pass the exception to the log.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-901778006


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez removed a comment on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908822120






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#discussion_r693912315



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -5988,6 +5996,18 @@ public VirtualMachine migrateVirtualMachine(Long vmId, Host destinationHost) thr
         return findMigratedVm(vm.getId(), vm.getType());
     }
 
+    private void checkVmDestinationServerCapacity(VMInstanceVO vm, Host destinationHost) {
+        // check server capacity
+        ServiceOfferingVO offering = _offeringDao.findById(vm.getId(), vm.getServiceOfferingId());
+        boolean hostHasCapacity = _capacityMgr.checkIfHostHasCpuCapability(destinationHost.getId(), offering.getCpu(), offering.getSpeed())
+                && _capacityMgr.checkIfHostHasCapacity(destinationHost.getId(), offering.getCpu() * offering.getSpeed(), offering.getRamSize() * 1024L * 1024L, false,
+                _capacityMgr.getClusterOverProvisioningFactor(destinationHost.getClusterId(), Capacity.CAPACITY_TYPE_CPU),
+                _capacityMgr.getClusterOverProvisioningFactor(destinationHost.getClusterId(), Capacity.CAPACITY_TYPE_MEMORY), false);
+        if (! hostHasCapacity) {

Review comment:
       ```suggestion
           if (!hostHasCapacity) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-901765734


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-911707154


   Kicking a new round of tests while is being tested
   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908780455


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-909400665


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-907114663


   @weizhouapache does this affect 4.15 too? If so, pl raise PR against 4.15 branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-909339739






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache closed pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908828273


   <b>Trillian Build Failed (tid-1844)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache edited a comment on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-901755822


   @andrijapanicsb @nvazquez 
   
   
   the following checks are added when deploy/start a vm with specified id.
   (1) host state (Up and Enabled)
   (2) DPDK enabled (if it is enabled on vm, host should be enabled also)
   (3) hypervisor capability (max guest limits)
   (4) server capacity
   
   not sure if users are happy with the checks.
   
   ps: (1) to (3) already exist in destination host check in vm migration. (4) is a new check in vm migration.
   
   =======UPDATE 2021-09-01===========
   
   We have decided to only add capacity check. the other checks are not added.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-901778433


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-909401444


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#discussion_r694497464



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -5988,6 +5996,18 @@ public VirtualMachine migrateVirtualMachine(Long vmId, Host destinationHost) thr
         return findMigratedVm(vm.getId(), vm.getType());
     }
 
+    private void checkVmDestinationServerCapacity(VMInstanceVO vm, Host destinationHost) {
+        // check server capacity
+        ServiceOfferingVO offering = _offeringDao.findById(vm.getId(), vm.getServiceOfferingId());
+        boolean hostHasCapacity = _capacityMgr.checkIfHostHasCpuCapability(destinationHost.getId(), offering.getCpu(), offering.getSpeed())

Review comment:
       Would it be simpler to use `checkIfHostHasCpuCapabilityAndCapacity`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez closed pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-901755822


   @andrijapanicsb @nvazquez 
   
   the following checks are added when deploy/start a vm with specified id.
   (1) host state (Up and Enabled)
   (2) DPDK enabled (if it is enabled on vm, host should be enabled also)
   (3) hypervisor capability (max guest limits)
   (4) server capacity
   
   not sure if users are happy with the checks.
   
   ps: (1) to (3) already exist in destination host check in vm migration. (4) is a new check in vm migration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908831047


   @nvazquez a Trillian-Jenkins test job (ubuntu18 mgmt + kvm-ubuntu18) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908780734






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-911709080


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-909339739


   <b>Trillian test result (tid-1845)</b>
   Environment: kvm-ubuntu18 (x2), Advanced Networking with Mgmt server u18
   Total time taken: 47260 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5339-t1845-kvm-ubuntu18.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_domain_vpc_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 83 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
   test_DeleteDomain | `Error` | 0.89 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 0.88 | test_accounts.py
   test_forceDeleteDomain | `Error` | 3.10 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.39 | test_accounts.py
   ContextSuite context=TestTemplateHierarchy>:teardown | `Error` | 425.51 | test_accounts.py
   test_03_1_create_iso_with_checksum_md5_negative | `Error` | 999.88 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 65.47 | test_iso.py
   test_01_migrate_VM_and_root_volume | `Error` | 72.08 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 51.01 | test_vm_life_cycle.py
   test_01_secure_vm_migration | `Error` | 112.08 | test_vm_life_cycle.py
   test_02_unsecure_vm_migration | `Error` | 170.18 | test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 48.24 | test_vm_life_cycle.py
   test_hostha_kvm_host_degraded | `Error` | 681.86 | test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Error` | 666.57 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-903728799


   @nvazquez 
   actually vm cannot be started or migrated if there is no enough server capacity in 4.15 and master.
   
   the process to deploy/start a vm without destination host is
   (1) check server capacity of all hosts
   (2) select a host
   (3) double check if host has enough capacity (because step 1 might take long time if there are many hosts). this step was added by #3728
   
   if destination host is specified,  step 1 and 2 are skipped for now. but there is still a new check in step 3.
   I am not sure if necessary to add an extra step to check server capacity (it takes few milliseconds) in this PR.
   
   current error 
   1. allow.deploy.vm.if.deploy.on.given.host.fails=false
   ![Screenshot from 2021-08-23 10-05-23](https://user-images.githubusercontent.com/57355700/130448669-0e6699cf-26b9-4cba-bb79-b6939b0ec572.png)
   
   2. allow.deploy.vm.if.deploy.on.given.host.fails=true
   ![Screenshot from 2021-08-23 10-09-46](https://user-images.githubusercontent.com/57355700/130448677-8722500e-1c32-4593-a386-a3efb29518ce.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-903729390


   > clgtm, minor changes to code format required (check suggestions)
   
   thanks @sureshanaparti , changes have been committed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez merged pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache closed pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908822448






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908822448


   @nvazquez a Trillian-Jenkins test job (ubuntu18 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-910028104


   <b>Trillian test result (tid-1869)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 52093 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5339-t1869-kvm-centos7.zip
   Smoke tests completed. 88 look OK, 3 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_deploy_vm_start_failure | `Error` | 63.18 | test_deploy_vm.py
   test_deploy_vm_volume_creation_failure | `Error` | 66.22 | test_deploy_vm.py
   test_vm_ha | `Error` | 60.51 | test_vm_ha.py
   test_vm_sync | `Error` | 125.86 | test_vm_sync.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908813581


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-902202600


   <b>Trillian test result (tid-1721)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34502 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5339-t1721-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Smoke tests completed. 89 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#discussion_r694497464



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -5988,6 +5996,18 @@ public VirtualMachine migrateVirtualMachine(Long vmId, Host destinationHost) thr
         return findMigratedVm(vm.getId(), vm.getType());
     }
 
+    private void checkVmDestinationServerCapacity(VMInstanceVO vm, Host destinationHost) {
+        // check server capacity
+        ServiceOfferingVO offering = _offeringDao.findById(vm.getId(), vm.getServiceOfferingId());
+        boolean hostHasCapacity = _capacityMgr.checkIfHostHasCpuCapability(destinationHost.getId(), offering.getCpu(), offering.getSpeed())

Review comment:
       Would it be simpler to use `checkIfHostHasCpuCapabilityAndCapacity` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908813984






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908819442


   <b>Trillian Build Failed (tid-1843)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5339: server: check server capacity when start/deploy a vm

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#issuecomment-908822120


   @blueorangutan test ubuntu18 kvm-centos7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #5339: server: check server capacity when start/deploy or migrate a vm

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5339:
URL: https://github.com/apache/cloudstack/pull/5339#discussion_r694497989



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -4935,9 +4935,17 @@ public void finalizeStop(VirtualMachineProfile profile, Answer answer) {
         boolean deployOnGivenHost = false;
         if (destinationHost != null) {
             s_logger.debug("Destination Host to deploy the VM is specified, specifying a deployment plan to deploy the VM");
-            plan = new DataCenterDeployment(vm.getDataCenterId(), destinationHost.getPodId(), destinationHost.getClusterId(), destinationHost.getId(), null, null);
-            if (!AllowDeployVmIfGivenHostFails.value()) {
-                deployOnGivenHost = true;
+            try {
+                checkVmDestinationServerCapacity(vm, destinationHost);

Review comment:
       Would it be simpler to use `_capacityMgr.checkIfHostHasCpuCapabilityAndCapacity` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org