You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/06/28 15:35:32 UTC
[GitHub] [yunikorn-core] craigcondit opened a new pull request, #584: [YUNIKORN-1845] Handle nil logger handle
craigcondit opened a new pull request, #584:
URL: https://github.com/apache/yunikorn-core/pull/584
### What is this PR for?
Calling log.Log(nil) can cause a panic. This needs to be handled properly.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1845
### How should this be tested?
Added unit test.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #584: [YUNIKORN-1845] Handle nil logger handle
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #584:
URL: https://github.com/apache/yunikorn-core/pull/584#issuecomment-1611669372
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/584?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#584](https://app.codecov.io/gh/apache/yunikorn-core/pull/584?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5657163) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/530533f78bdcc733d3075b6ff41bea2e8d999b80?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (530533f) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #584 +/- ##
=======================================
Coverage 76.41% 76.41%
=======================================
Files 74 74
Lines 12209 12212 +3
=======================================
+ Hits 9329 9332 +3
Misses 2569 2569
Partials 311 311
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/log/logger.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2xvZy9sb2dnZXIuZ28=) | `90.37% <100.00%> (+0.21%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #584: [YUNIKORN-1845] Handle nil logger handle
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #584: [YUNIKORN-1845] Handle nil logger handle
URL: https://github.com/apache/yunikorn-core/pull/584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org